You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/01 18:55:00 UTC

[jira] [Updated] (ARROW-2505) [C++] Disable MSVC warning C4800

     [ https://issues.apache.org/jira/browse/ARROW-2505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ASF GitHub Bot updated ARROW-2505:
----------------------------------
    Labels: build pull-request-available windows  (was: build windows)

> [C++] Disable MSVC warning C4800
> --------------------------------
>
>                 Key: ARROW-2505
>                 URL: https://issues.apache.org/jira/browse/ARROW-2505
>             Project: Apache Arrow
>          Issue Type: Wish
>          Components: C++
>            Reporter: Antoine Pitrou
>            Priority: Major
>              Labels: build, pull-request-available, windows
>
> This warning is practically pointless, and since we treat warnings as errors on Appveyor, it imposes spurious back-and-forths to fix it when it occurs.
> https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4800
> {quote}This warning is generated when a value that is not bool is assigned or coerced into type bool. Typically, this message is caused by assigning int variables to bool variables where the int variable contains only values true and false, and could be redeclared as type bool. If you cannot rewrite the expression to use type bool, then you can add "!=0" to the expression, which gives the expression type bool. Casting the expression to type bool does not disable the warning, which is by design.
> This warning is no longer generated in Visual Studio 2017.
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)