You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/07/01 02:17:24 UTC
[jira] [Commented] (FLINK-994) Replace DataInput and DataOutput of
IOReadableWritable with DataInputView and DataOutputView
[ https://issues.apache.org/jira/browse/FLINK-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14048347#comment-14048347 ]
ASF GitHub Bot commented on FLINK-994:
--------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/incubator-flink/pull/53
[FLINK-994] Replaced DataInput and DataOutput with DataInputView and DataOutputView
I replaced the DataInput and DataOutput parameters by DataInputView and DataOutputView in the IOReadableWritable interface. Thus, I also added wrappers for DataInputStream, DataOutputStream, ObjectOutputStream and ObjectInputStream to make them compatible with the new read and write methods.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/incubator-flink FLINK-994
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-flink/pull/53.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #53
----
commit bf0d7cf252f51fc3e79e2655d91de1781940bd5b
Author: Till Rohrmann <ti...@gmail.com>
Date: 2014-06-29T17:08:31Z
Replaced DataInput and DataOutput with DataInputView and DataOutputView
----
> Replace DataInput and DataOutput of IOReadableWritable with DataInputView and DataOutputView
> --------------------------------------------------------------------------------------------
>
> Key: FLINK-994
> URL: https://issues.apache.org/jira/browse/FLINK-994
> Project: Flink
> Issue Type: Improvement
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
>
> The DataInput and DataOutput view are not well designed interfaces with a limited function set. Therefore, we should replace the DataInput and DataOutput by the Flink defined DataInputView and DataOutputView in the IOReadableWritable interface. This is a preparative step for the serializer and input/output abstraction rework.
--
This message was sent by Atlassian JIRA
(v6.2#6252)