You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yuluo-yx (via GitHub)" <gi...@apache.org> on 2026/08/29 16:22:33 UTC
[I] Reject non-finite available metric samples [rocketmq-dashboard]
yuluo-yx opened a new issue, #2778:
URL: https://github.com/apache/rocketmq-dashboard/issues/2778
## Problem
MetricSample accepts NaN and infinite values as AVAILABLE. Those samples can poison alert aggregation, persistence, and chart rendering even though unavailable samples already have explicit availability semantics.
## Expected behavior
Require every AVAILABLE metric value to be finite and fail fast at the normalized metric boundary.
## Verification
Extend MetricSample tests with NaN and positive infinity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Reject non-finite available metric samples [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #2778:
URL: https://github.com/apache/rocketmq-dashboard/issues/2778#issuecomment-5555728541
This issue has been automatically closed because there has been no activity for 7 days. If you believe this issue is still relevant, please reopen it with updated information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Reject non-finite available metric samples [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #2778: Reject non-finite available metric samples
URL: https://github.com/apache/rocketmq-dashboard/issues/2778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Reject non-finite available metric samples [rocketmq-dashboard]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #2778:
URL: https://github.com/apache/rocketmq-dashboard/issues/2778#issuecomment-5463734268
**Issue Evaluation**
Category: `enhancement` | Status: **Evaluated**
Thank you for this proposal. After reviewing the current codebase, the `MetricSample` class and the normalized metric boundary mentioned in this issue **do not yet exist** in `apache/rocketmq-dashboard`.
This appears to be a proposal for new validation logic rather than a fix for existing code. The idea of rejecting non-finite (`NaN`, `±Infinity`) values at the metric ingestion boundary is sound defensive engineering.
**Feasibility:** Feasible — would require creating a `MetricSample` model with finite-value validation.
**Scope:** New code; no backward-compatibility risk.
**Suggestion:** If this is part of a broader metrics subsystem design, consider bundling it with the other metric-related proposals for a single design discussion.
---
*Automated evaluation by RockteMQ-AI*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org