You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2023/01/20 12:09:31 UTC
[GitHub] [ignite-3] tkalkirill opened a new pull request, #1557: IGNITE-18596 Add RaftGroupConfiguration to MvTableStorage#finishRebalancePartition
tkalkirill opened a new pull request, #1557:
URL: https://github.com/apache/ignite-3/pull/1557
https://issues.apache.org/jira/browse/IGNITE-18596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1557: IGNITE-18596 Add RaftGroupConfiguration to MvTableStorage#finishRebalancePartition
Posted by GitBox <gi...@apache.org>.
tkalkirill commented on code in PR #1557:
URL: https://github.com/apache/ignite-3/pull/1557#discussion_r1082521831
##########
modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/AbstractMvTableStorageTest.java:
##########
@@ -917,4 +936,26 @@ private static List<byte[]> toListOfByteArrays(Cursor<ReadResult> cursor) {
return cursor.stream().map(ReadResult::binaryRow).map(BinaryRow::bytes).collect(toList());
}
}
+
+ private static RaftGroupConfiguration createRandomRaftGroupConfiguration() {
+ Random random = new Random();
Review Comment:
Fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] tkalkirill merged pull request #1557: IGNITE-18596 Add RaftGroupConfiguration to MvTableStorage#finishRebalancePartition
Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill merged PR #1557:
URL: https://github.com/apache/ignite-3/pull/1557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] SammyVimes commented on a diff in pull request #1557: IGNITE-18596 Add RaftGroupConfiguration to MvTableStorage#finishRebalancePartition
Posted by GitBox <gi...@apache.org>.
SammyVimes commented on code in PR #1557:
URL: https://github.com/apache/ignite-3/pull/1557#discussion_r1082490021
##########
modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/AbstractMvTableStorageTest.java:
##########
@@ -917,4 +936,26 @@ private static List<byte[]> toListOfByteArrays(Cursor<ReadResult> cursor) {
return cursor.stream().map(ReadResult::binaryRow).map(BinaryRow::bytes).collect(toList());
}
}
+
+ private static RaftGroupConfiguration createRandomRaftGroupConfiguration() {
+ Random random = new Random();
Review Comment:
Better add a seed here, make tests repeatable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org