You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by joeymcallister <gi...@git.apache.org> on 2016/10/12 00:37:32 UTC
[GitHub] incubator-geode pull request #257: Feature/geode 1952
GitHub user joeymcallister opened a pull request:
https://github.com/apache/incubator-geode/pull/257
Feature/geode 1952
Adds `geode-book` directory for building the end-user documentation from the content in the `geode-docs` directory. Updates the `geode-docs` README for building the docs locally.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joeymcallister/incubator-geode feature/GEODE-1952
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-geode/pull/257.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #257
----
commit d9d8b59b325c0581ff54c97db91b52adb0f4714c
Author: Joey McAllister <jm...@pivotal.io>
Date: 2016-10-11T20:34:06Z
Add geode-book dir for docs build
commit 1c98ba56cf609ee61b5872cd696db95d4bcfebaa
Author: Joey McAllister <jm...@pivotal.io>
Date: 2016-10-11T21:06:36Z
Revert "Add geode-book dir for docs build"
This reverts commit d9d8b59b325c0581ff54c97db91b52adb0f4714c.
commit e9b44af4e996ac739cd632704e925d525b9fcca1
Author: Joey McAllister <jm...@pivotal.io>
Date: 2016-10-11T21:24:40Z
GEODE-1952 Add geode-book dir to build docs
commit 7592ba1027e51ae84dcfbed297534522557fbbec
Author: Joey McAllister <jm...@pivotal.io>
Date: 2016-10-11T21:38:11Z
GEODE-1952 Remove old redirects
commit 36d1f39d68a847dc574e267c51efa89f9c980bd6
Author: Joey McAllister <jm...@pivotal.io>
Date: 2016-10-11T22:54:54Z
GEODE-1952 Update docs README, config
commit 0b31275966beaf4039afd913b8644c81a32c1758
Author: Joey McAllister <jm...@pivotal.io>
Date: 2016-10-12T00:29:12Z
GEODE-1952 Add book README; edit docs README, CONTRIBUTE
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #257: Feature/geode 1952
Posted by joeymcallister <gi...@git.apache.org>.
Github user joeymcallister closed the pull request at:
https://github.com/apache/incubator-geode/pull/257
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #257: Feature/geode 1952
Posted by joeymcallister <gi...@git.apache.org>.
Github user joeymcallister commented on the issue:
https://github.com/apache/incubator-geode/pull/257
Thanks, Dave. Closing this PR to make the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #257: Feature/geode 1952
Posted by davebarnes97 <gi...@git.apache.org>.
Github user davebarnes97 commented on the issue:
https://github.com/apache/incubator-geode/pull/257
Nice work! Two comments:
1. As mentioned, I get one orphaned file during the bookbinder build: pdf_header.html.
2. README.md sugggestions:
a. "Bookbinder is a gem" -> "Bookbinder is a Ruby gem"
b. Why show config.yml? Potential maintenance headache going forward.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---