You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Bob Ziuchkovski (Created) (JIRA)" <ji...@apache.org> on 2012/02/13 23:43:04 UTC

[jira] [Created] (FELIX-3351) Permissions.createPermission(String name, String action, Class target) Fails for action == null

Permissions.createPermission(String name, String action, Class target) Fails for action == null
-----------------------------------------------------------------------------------------------

                 Key: FELIX-3351
                 URL: https://issues.apache.org/jira/browse/FELIX-3351
             Project: Felix
          Issue Type: Bug
          Components: Framework Security
    Affects Versions: framework.security-1.4.1
            Reporter: Bob Ziuchkovski
            Priority: Minor


java.security.Permission has a single constructor, Permission(String name).  While many subclasses add another constructor with sig (String name, String actions), this is not a requirement for Permission subclasses and custom permissions without the actions arg are not properly handled by createPermission().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (FELIX-3351) Permissions.createPermission(String name, String action, Class target) Fails for action == null

Posted by "Bob Ziuchkovski (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bob Ziuchkovski updated FELIX-3351:
-----------------------------------

    Attachment: felix_permission_noaction.patch
    
> Permissions.createPermission(String name, String action, Class target) Fails for action == null
> -----------------------------------------------------------------------------------------------
>
>                 Key: FELIX-3351
>                 URL: https://issues.apache.org/jira/browse/FELIX-3351
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework Security
>    Affects Versions: framework.security-1.4.1
>            Reporter: Bob Ziuchkovski
>            Priority: Minor
>         Attachments: felix_permission_noaction.patch
>
>
> java.security.Permission has a single constructor, Permission(String name).  While many subclasses add another constructor with sig (String name, String actions), this is not a requirement for Permission subclasses and custom permissions without the actions arg are not properly handled by createPermission().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (FELIX-3351) Permissions.createPermission(String name, String action, Class target) Fails for action == null

Posted by "Bob Ziuchkovski (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207315#comment-13207315 ] 

Bob Ziuchkovski commented on FELIX-3351:
----------------------------------------

Updated the patch...original approach was wrong.
                
> Permissions.createPermission(String name, String action, Class target) Fails for action == null
> -----------------------------------------------------------------------------------------------
>
>                 Key: FELIX-3351
>                 URL: https://issues.apache.org/jira/browse/FELIX-3351
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework Security
>    Affects Versions: framework.security-1.4.1
>            Reporter: Bob Ziuchkovski
>            Priority: Minor
>         Attachments: felix_permission_noaction.patch
>
>
> java.security.Permission has a single constructor, Permission(String name).  While many subclasses add another constructor with sig (String name, String actions), this is not a requirement for Permission subclasses and custom permissions without the actions arg are not properly handled by createPermission().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (FELIX-3351) Permissions.createPermission(String name, String action, Class target) Fails for action == null

Posted by "Karl Pauls (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207743#comment-13207743 ] 

Karl Pauls commented on FELIX-3351:
-----------------------------------

Well, it is not a requirement for normal java permissions. However, the PermissionInfo javadoc does make it a requirement. The javadoc does say: 

"The fully qualified class name of the permission represented by this PermissionInfo. The class must be a subclass of java.security.Permission and must define a 2-argument constructor that takes a name string and an actions string."

In other words, im not sure it should be possible to hit this problem. Im not against adding your fix but can you give me a bit more background and maybe a use case where you manage to specifiy a name only permission info that makes this fail?
                
> Permissions.createPermission(String name, String action, Class target) Fails for action == null
> -----------------------------------------------------------------------------------------------
>
>                 Key: FELIX-3351
>                 URL: https://issues.apache.org/jira/browse/FELIX-3351
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework Security
>    Affects Versions: framework.security-1.4.1
>            Reporter: Bob Ziuchkovski
>            Assignee: Karl Pauls
>            Priority: Minor
>         Attachments: felix_permission_noaction.patch
>
>
> java.security.Permission has a single constructor, Permission(String name).  While many subclasses add another constructor with sig (String name, String actions), this is not a requirement for Permission subclasses and custom permissions without the actions arg are not properly handled by createPermission().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (FELIX-3351) Permissions.createPermission(String name, String action, Class target) Fails for action == null

Posted by "Bob Ziuchkovski (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bob Ziuchkovski updated FELIX-3351:
-----------------------------------

    Attachment:     (was: felix_permission_noaction.patch)
    
> Permissions.createPermission(String name, String action, Class target) Fails for action == null
> -----------------------------------------------------------------------------------------------
>
>                 Key: FELIX-3351
>                 URL: https://issues.apache.org/jira/browse/FELIX-3351
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework Security
>    Affects Versions: framework.security-1.4.1
>            Reporter: Bob Ziuchkovski
>            Priority: Minor
>         Attachments: felix_permission_noaction.patch
>
>
> java.security.Permission has a single constructor, Permission(String name).  While many subclasses add another constructor with sig (String name, String actions), this is not a requirement for Permission subclasses and custom permissions without the actions arg are not properly handled by createPermission().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (FELIX-3351) Permissions.createPermission(String name, String action, Class target) Fails for action == null

Posted by "Karl Pauls (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Karl Pauls reassigned FELIX-3351:
---------------------------------

    Assignee: Karl Pauls
    
> Permissions.createPermission(String name, String action, Class target) Fails for action == null
> -----------------------------------------------------------------------------------------------
>
>                 Key: FELIX-3351
>                 URL: https://issues.apache.org/jira/browse/FELIX-3351
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework Security
>    Affects Versions: framework.security-1.4.1
>            Reporter: Bob Ziuchkovski
>            Assignee: Karl Pauls
>            Priority: Minor
>         Attachments: felix_permission_noaction.patch
>
>
> java.security.Permission has a single constructor, Permission(String name).  While many subclasses add another constructor with sig (String name, String actions), this is not a requirement for Permission subclasses and custom permissions without the actions arg are not properly handled by createPermission().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (FELIX-3351) Permissions.createPermission(String name, String action, Class target) Fails for action == null

Posted by "Bob Ziuchkovski (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bob Ziuchkovski updated FELIX-3351:
-----------------------------------

    Attachment: felix_permission_noaction.patch

Simple patch attached.
                
> Permissions.createPermission(String name, String action, Class target) Fails for action == null
> -----------------------------------------------------------------------------------------------
>
>                 Key: FELIX-3351
>                 URL: https://issues.apache.org/jira/browse/FELIX-3351
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework Security
>    Affects Versions: framework.security-1.4.1
>            Reporter: Bob Ziuchkovski
>            Priority: Minor
>         Attachments: felix_permission_noaction.patch
>
>
> java.security.Permission has a single constructor, Permission(String name).  While many subclasses add another constructor with sig (String name, String actions), this is not a requirement for Permission subclasses and custom permissions without the actions arg are not properly handled by createPermission().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira