[GitHub] beliefer commented on a change in pull request #23865: [SPARK-26957][SCHEDULER] Config properties for spark dynamic scheduler pools

[GitBox <gi...@apache.org>]

beliefer commented on a change in pull request #23865: [SPARK-26957][SCHEDULER] Config properties for spark dynamic scheduler pools
URL: https://github.com/apache/spark/pull/23865#discussion_r259208670
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/scheduler/SchedulableBuilder.scala
 ##########
 @@ -66,9 +68,9 @@ private[spark] class FairSchedulableBuilder(val rootPool: Pool, conf: SparkConf)
   val WEIGHT_PROPERTY = "weight"
   val POOL_NAME_PROPERTY = "@name"
   val POOLS_PROPERTY = "pool"
-  val DEFAULT_SCHEDULING_MODE = SchedulingMode.FIFO
-  val DEFAULT_MINIMUM_SHARE = 0
-  val DEFAULT_WEIGHT = 1
+  val defaultSchedulingMode = SchedulingMode.withName(conf.get(SCHEDULER_DEFAULT_SCHEDULING_MODE))
 
 Review comment:
   This change is good.
   If user open the spark fair scheduler,the default pool always use fifo mode.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org