You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "Kvicii.Yu (Jira)" <ji...@apache.org> on 2022/01/19 14:24:00 UTC

[jira] (KAFKA-13590) Rename InternalTopologyBuilder's #topicGroups method to be more descriptive

    [ https://issues.apache.org/jira/browse/KAFKA-13590 ]


    Kvicii.Yu deleted comment on KAFKA-13590:
    -----------------------------------

was (Author: JIRAUSER283467):
rename is a problem.But what is more appropriate?

> Rename InternalTopologyBuilder's #topicGroups method to be more descriptive
> ---------------------------------------------------------------------------
>
>                 Key: KAFKA-13590
>                 URL: https://issues.apache.org/jira/browse/KAFKA-13590
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: A. Sophie Blee-Goldman
>            Priority: Minor
>
> Pretty much what the title says, it can be difficult to figure out what this method is actually returning based on the method name.. At least javadocs were added in a recent PR, but  ideally you nwouldn't need to visit the method's implementation at all to understand its function
>  
> See [https://github.com/apache/kafka/pull/11600/files#r768947553|https://github.com/apache/kafka/pull/11600/files#r768947553]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)