You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/15 01:53:38 UTC
[GitHub] [apisix] gy09535 opened a new issue #2425: bug: zipkin plugin can not work with new config when plugin config is change
gy09535 opened a new issue #2425:
URL: https://github.com/apache/apisix/issues/2425
### Issue description
When the zipkin plugin endpoint is change , zipkin always use old endpoint to report
I think the issue cause of this code :https://github.com/apache/apisix/blob/master/apisix/plugins/zipkin.lua#L111 , we should add the endpoint as the key.
### Environment
* apisix version (cmd: `apisix version`):1.5
* OS:
### Minimal test code / Steps to reproduce the issue
1.
2.
3.
### What's the actual result? (including assertion message & call stack if applicable)
### What's the expected result?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis edited a comment on issue #2425: bug: zipkin plugin can not work with new config when plugin config is change
Posted by GitBox <gi...@apache.org>.
membphis edited a comment on issue #2425:
URL: https://github.com/apache/apisix/issues/2425#issuecomment-711033622
confirm that is a bug, welcome PR ^_^
we need a better `key` here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gy09535 commented on issue #2425: bug: zipkin plugin can not work with new config when plugin config is change
Posted by GitBox <gi...@apache.org>.
gy09535 commented on issue #2425:
URL: https://github.com/apache/apisix/issues/2425#issuecomment-709950481
please confirm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gy09535 edited a comment on issue #2425: bug: zipkin plugin can not work with new config when plugin config is change
Posted by GitBox <gi...@apache.org>.
gy09535 edited a comment on issue #2425:
URL: https://github.com/apache/apisix/issues/2425#issuecomment-714317928
> @gy09535 would like to submit a PR to fix this bug?
>
> we can use a different key, then we can fix this issue.
After check, I make a mistake , the "core.lrucache.plugin_ctx" use the config version as the key, so when the config is changed ,the version is always changed, so it can use new value. I will close this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gy09535 commented on issue #2425: bug: zipkin plugin can not work with new config when plugin config is change
Posted by GitBox <gi...@apache.org>.
gy09535 commented on issue #2425:
URL: https://github.com/apache/apisix/issues/2425#issuecomment-711827483
> @gy09535 would like to submit a PR to fix this bug?
>
> we can use a different key, then we can fix this issue.
yeah, I will fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gy09535 commented on issue #2425: bug: zipkin plugin can not work with new config when plugin config is change
Posted by GitBox <gi...@apache.org>.
gy09535 commented on issue #2425:
URL: https://github.com/apache/apisix/issues/2425#issuecomment-714317928
> @gy09535 would like to submit a PR to fix this bug?
>
> we can use a different key, then we can fix this issue.
After check, I make a mistake , the "core.lrucache.plugin_ctx" use the config version as the key, so when the config is changed ,the version is always change, so it can use new value. I will close this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gy09535 closed issue #2425: bug: zipkin plugin can not work with new config when plugin config is change
Posted by GitBox <gi...@apache.org>.
gy09535 closed issue #2425:
URL: https://github.com/apache/apisix/issues/2425
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gy09535 commented on issue #2425: bug: zipkin plugin can not work with new config when plugin config is change
Posted by GitBox <gi...@apache.org>.
gy09535 commented on issue #2425:
URL: https://github.com/apache/apisix/issues/2425#issuecomment-711474497
got it, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on issue #2425: bug: zipkin plugin can not work with new config when plugin config is change
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #2425:
URL: https://github.com/apache/apisix/issues/2425#issuecomment-711607503
@gy09535 would like to submit a PR to fix this bug?
we can use a different key, then we can fix this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on issue #2425: bug: zipkin plugin can not work with new config when plugin config is change
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #2425:
URL: https://github.com/apache/apisix/issues/2425#issuecomment-711033622
confirm that is a bug, welcome PR ^_^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gy09535 edited a comment on issue #2425: bug: zipkin plugin can not work with new config when plugin config is change
Posted by GitBox <gi...@apache.org>.
gy09535 edited a comment on issue #2425:
URL: https://github.com/apache/apisix/issues/2425#issuecomment-711827483
> @gy09535 would like to submit a PR to fix this bug?
>
> we can use a different key, then we can fix this issue.
yeah, please assign to me, I will fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org