You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by gi...@apache.org on 2014/06/11 07:49:14 UTC

git commit: updated refs/heads/4.4-forward to 0190c93

Repository: cloudstack
Updated Branches:
  refs/heads/4.4-forward 09a357fb9 -> 0190c9366


CLOUDSTACK-6780: Resolved cleanup issue in portable ip test cases


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/0190c936
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/0190c936
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/0190c936

Branch: refs/heads/4.4-forward
Commit: 0190c936689fc252e51b7c412283c128b5386b24
Parents: 09a357f
Author: Ashutosh K <as...@clogeny.com>
Authored: Tue May 27 07:02:04 2014 -0700
Committer: Girish Shilamkar <gi...@clogeny.com>
Committed: Wed Jun 11 11:18:26 2014 +0530

----------------------------------------------------------------------
 test/integration/component/test_portable_ip.py | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/0190c936/test/integration/component/test_portable_ip.py
----------------------------------------------------------------------
diff --git a/test/integration/component/test_portable_ip.py b/test/integration/component/test_portable_ip.py
index 847bb4a..77a5ab6 100644
--- a/test/integration/component/test_portable_ip.py
+++ b/test/integration/component/test_portable_ip.py
@@ -1103,21 +1103,27 @@ class TestDisassociatePublicIp(cloudstackTestCase):
             self.fail("Failed to create portable ip: %s" % e)
 
         try:
-            self.user_account = Account.create(
+            self.otherAccount = Account.create(
                             self.apiclient,
                             self.services["account"],
                             domainid=self.domain.id
                             )
+            self.cleanup.append(self.otherAccount)
 
-            self.api_client_user = self.testClient.getUserApiClient(
-                                            UserName=self.user_account.name,
-                                            DomainName=self.user_account.domain
+            self.apiclientOtherAccount = self.testClient.getUserApiClient(
+                                            UserName=self.otherAccount.name,
+                                            DomainName=self.otherAccount.domain
                                             )
 
+            # Trying to disassociate portable ip using
+            # api client of other account than the one
+            # used to create portable ip
             with self.assertRaises(Exception):
-                portableip.delete(self.api_client_user)
-        except Exception as e:
+                portableip.delete(self.apiclientOtherAccount)
+
+            # Disassociate IP using api client of account used to create it
             portableip.delete(self.apiclient)
+        except Exception as e:
             self.fail("Exception while disassociating portable ip: %s" % e)
         return