You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/14 06:49:08 UTC

[GitHub] [incubator-nuttx] jlaitine opened a new pull request #1045: Stm32h7 dma fixes

jlaitine opened a new pull request #1045:
URL: https://github.com/apache/incubator-nuttx/pull/1045


   ## Summary
   
   This set of patches fix some issues we have encountered with dma driver:
   - Compiling the DMA code for stm32h7 with CONFIG_DEBUG_ASSERTIONS=y fail
   - It was not possible to DMA to/from AXI sram if CONFIG_STM32H7_DMACAPABLE=y
   - When doing TX DMA (e.g. in SPI driver in simplex-tx mode), it should not be necessary to
   align the data buffers to the cache line. Doing only clean is perfectly fine to a full cache line, even if it contains some other data that is just managed by CPU. Also, since the cache management
   (clean/invalidate) is being done from outside the DMA driver, probably checking whether it is done correctly should be done there as well.
   
   ## Impact
   
   This gives possibility to send arbitrary number of bytes from memory to peripheral using DMA also when using write-back cache
   
   ## Testing
   
   This has been tested with sending arbitrary long packets from AXI sram to SPI simplex tx, in write-back cache configuration on stm32h743zi platform.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on pull request #1045: Stm32h7 dma fixes

Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #1045:
URL: https://github.com/apache/incubator-nuttx/pull/1045#issuecomment-628681515


   > @patacongo - What do you want to do about the alighment?
   
   You can ignore them.  Looks like a tool problem to me.
   
   The coding standard and the tools both expect braces to appear in column 4 * N where N is th indention level.  But this rule is not usually enforced in data, only in code.  I don't know what is triggering the check here.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] davids5 commented on pull request #1045: Stm32h7 dma fixes

Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #1045:
URL: https://github.com/apache/incubator-nuttx/pull/1045#issuecomment-628542381


   @jlaitine - this looks good to me.
   
   @patacongo - What do you want to do about the alighment?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo merged pull request #1045: Stm32h7 dma fixes

Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #1045:
URL: https://github.com/apache/incubator-nuttx/pull/1045


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] jlaitine commented on pull request #1045: Stm32h7 dma fixes

Posted by GitBox <gi...@apache.org>.
jlaitine commented on pull request #1045:
URL: https://github.com/apache/incubator-nuttx/pull/1045#issuecomment-628447066


   I don't know if I should do something with the existing "brace alignment" style errors. The existing alignment looks good to me?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org