You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/08/08 07:37:44 UTC
[GitHub] [camel-k] lburgazzoli opened a new pull request, #3520: feat: also build 1.9.x and 1.8.x as part of nightly builds
lburgazzoli opened a new pull request, #3520:
URL: https://github.com/apache/camel-k/pull/3520
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3520: feat: also build 1.9.x and 1.8.x as part of nightly builds
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3520:
URL: https://github.com/apache/camel-k/pull/3520#issuecomment-1210248193
@lburgazzoli feel free to turn it into a ready PR if you're done and we can see the result in during next nightly build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] lburgazzoli commented on pull request #3520: feat: also build 1.9.x and 1.8.x as part of nightly builds
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on PR #3520:
URL: https://github.com/apache/camel-k/pull/3520#issuecomment-1207928479
> Nice stuff. We probably will need some live test on the `release` but it's good for me.
yeah, I think that this is really an interim solution till we get #3260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] lburgazzoli commented on pull request #3520: feat: also build 1.9.x and 1.8.x as part of nightly builds
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on PR #3520:
URL: https://github.com/apache/camel-k/pull/3520#issuecomment-1207776307
@squakez I know there is https://github.com/apache/camel-k/issues/3260 but in the meantime it would be nice to have some nightly build also for the 1.9.x and 1.8.x so people have the chance to test also such nightly release after backports before a release is cut.
let me know if it make sense, if not, flee free to close this pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez merged pull request #3520: feat: also build 1.9.x and 1.8.x as part of nightly builds
Posted by GitBox <gi...@apache.org>.
squakez merged PR #3520:
URL: https://github.com/apache/camel-k/pull/3520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on a diff in pull request #3520: feat: also build 1.9.x and 1.8.x as part of nightly builds
Posted by GitBox <gi...@apache.org>.
squakez commented on code in PR #3520:
URL: https://github.com/apache/camel-k/pull/3520#discussion_r940018860
##########
.github/workflows/release-workflow.yml:
##########
@@ -0,0 +1,115 @@
+# ---------------------------------------------------------------------------
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+name: release
+
+on:
+ workflow_call:
+ inputs:
+ ref:
+ required: true
+ type: string
+ goVersion:
+ required: true
+ type: string
+ javaVersion:
+ required: true
+ type: string
+ secrets:
+ registryUsername:
+ required: true
+ registryPassword:
+ required: true
+
+jobs:
+ release:
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Set up JDK ${{ inputs.javaVersion }}
+ uses: actions/setup-java@v2
+ with:
+ version: ${{ inputs.javaVersion }}
+ distribution: "temurin"
+ - name: Install Go ${{ inputs.goVersion }}
+ uses: actions/setup-go@v2
+ with:
+ go-version: ${{ inputs.goVersion }}
+ - name: Checkout code
+ uses: actions/checkout@v2
+ with:
+ ref: ${{ inputs.ref }}
+ - name: Cache modules
+ uses: actions/cache@v1
+ with:
+ path: ~/go/pkg/mod
+ key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
+ restore-keys: |
+ ${{ runner.os }}-go-
+ - name: Get nightly version
+ shell: bash
+ run: |
+ V=$(make get-version | sed s/-SNAPSHOT/-nightly/)
+ echo "VERSION=$V" >> $GITHUB_ENV
+ - name: Global Env
+ run: |
+ echo "Using VERSION=${{ env.VERSION }}"
+
+ IMAGE_NAME=docker.io/${TEST_DOCKER_HUB_USERNAME:-testcamelk}/camel-k
+ echo "Using IMAGE_NAME=$IMAGE_NAME"
+ echo "IMAGE_NAME=$IMAGE_NAME" >> $GITHUB_ENV
+
+ MAVEN_REPOSITORY=$(make get-staging-repo)
+ echo "Using MAVEN_REPOSITORY=$MAVEN_REPOSITORY"
+ echo "MAVEN_REPOSITORY=$MAVEN_REPOSITORY" >> $GITHUB_ENV
+
+ - name: Login to Container Registry
+ uses: docker/login-action@v1
+ with:
+ registry: quay.io
Review Comment:
I guess it should login to docker hub instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] lburgazzoli commented on a diff in pull request #3520: feat: also build 1.9.x and 1.8.x as part of nightly builds
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on code in PR #3520:
URL: https://github.com/apache/camel-k/pull/3520#discussion_r940067401
##########
.github/workflows/release-workflow.yml:
##########
@@ -0,0 +1,115 @@
+# ---------------------------------------------------------------------------
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+name: release
+
+on:
+ workflow_call:
+ inputs:
+ ref:
+ required: true
+ type: string
+ goVersion:
+ required: true
+ type: string
+ javaVersion:
+ required: true
+ type: string
+ secrets:
+ registryUsername:
+ required: true
+ registryPassword:
+ required: true
+
+jobs:
+ release:
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Set up JDK ${{ inputs.javaVersion }}
+ uses: actions/setup-java@v2
+ with:
+ version: ${{ inputs.javaVersion }}
+ distribution: "temurin"
+ - name: Install Go ${{ inputs.goVersion }}
+ uses: actions/setup-go@v2
+ with:
+ go-version: ${{ inputs.goVersion }}
+ - name: Checkout code
+ uses: actions/checkout@v2
+ with:
+ ref: ${{ inputs.ref }}
+ - name: Cache modules
+ uses: actions/cache@v1
+ with:
+ path: ~/go/pkg/mod
+ key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
+ restore-keys: |
+ ${{ runner.os }}-go-
+ - name: Get nightly version
+ shell: bash
+ run: |
+ V=$(make get-version | sed s/-SNAPSHOT/-nightly/)
+ echo "VERSION=$V" >> $GITHUB_ENV
+ - name: Global Env
+ run: |
+ echo "Using VERSION=${{ env.VERSION }}"
+
+ IMAGE_NAME=docker.io/${TEST_DOCKER_HUB_USERNAME:-testcamelk}/camel-k
+ echo "Using IMAGE_NAME=$IMAGE_NAME"
+ echo "IMAGE_NAME=$IMAGE_NAME" >> $GITHUB_ENV
+
+ MAVEN_REPOSITORY=$(make get-staging-repo)
+ echo "Using MAVEN_REPOSITORY=$MAVEN_REPOSITORY"
+ echo "MAVEN_REPOSITORY=$MAVEN_REPOSITORY" >> $GITHUB_ENV
+
+ - name: Login to Container Registry
+ uses: docker/login-action@v1
+ with:
+ registry: quay.io
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3520: feat: also build 1.9.x and 1.8.x as part of nightly builds
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3520:
URL: https://github.com/apache/camel-k/pull/3520#issuecomment-1211605347
It seems the workflow failed: https://github.com/apache/camel-k/actions/runs/2836308573/workflow
```
error parsing called workflow "./.github/workflows/release-workflow.yaml": failed to fetch workflow: workflow was not found.
```
but the file is there. Not sure why it complains.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] lburgazzoli commented on pull request #3520: feat: also build 1.9.x and 1.8.x as part of nightly builds
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on PR #3520:
URL: https://github.com/apache/camel-k/pull/3520#issuecomment-1211610388
damn, it's been the n-th time I'm doing this mistake ....
opened a pr https://github.com/apache/camel-k/pull/3535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org