[GitHub] [activemq] ehossack-aws commented on pull request #682: [AMQ-7309] Update to jakarta.jms/jakarta.jms-api:2.0.3

[GitBox <gi...@apache.org>]

ehossack-aws commented on pull request #682:
URL: https://github.com/apache/activemq/pull/682#issuecomment-892952534


   I'm wondering if a constructive way to move this conversation forward, and JMS 2.0 support in general, would be to define a series of `JMS20CompatibilityTest`s, that utilize the APIs and act accordingly.
   The tests could assert that UOEs are thrown when expected, and certain functionality works across 2.0 APIs when UOEs are not expected.
   A feature-complete reiteration of the JMS spec might not have value, but there's certainly core areas that could be covered.
   
   As new support comes for methods (subtasks implemented of https://issues.apache.org/jira/browse/AMQ-7309) those tests could be altered as functional, and potentially all tests moved or relocated upon feature-complete spec.
   
   That way too, we're talking about specific test cases in ActiveMQ and not across QPID (valid to support though they may be).
   How does that sound? The action items there would be:
   - @mattrpav to add a series of basic tests that cover the altered APIs
   - @gemmellr to suggest a test (either before or after matt adds the tests) that could cover the use case in a clear/concise manner (e.g. Build/Operate/Check), that would move the convo forward
    
   (admittedly as a passive watcher of this PR, I'm having a hard time following your suggestions, i.e. understanding how the implementation of delivery delay that _does not_ throw exceptions in the case of trying to mutate or access data that isn't supported could provide return values with meaning, and the linked test case I'm assuming is failing due to this implementation decision: https://github.com/apache/qpid-jms/blob/6775a2e027d8963cda4f1a7dc75b115c5def4d47/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsSession.java#L999 - in which case QPID could choose to catch the UOE in a similar manner)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org