[GitHub] kristw commented on issue #6814: [SIP-16] Proposal for loading additional polygon encodings

[GitBox <gi...@apache.org>]

kristw commented on issue #6814: [SIP-16] Proposal for loading additional polygon encodings
URL: https://github.com/apache/incubator-superset/issues/6814#issuecomment-463174463
 
 
   > data would have to pre-joined with all polygons in the datasource
   
   I am not sure I fully understand the data. What is each data point? Is it individual data point or aggregated? Could you give a more concrete example? 
   
   What does `geohash.decode` and `geohash.bbox` do? What is the `code` argument?
   
   Regarding `viz.py` and embeddable components. Most of the visualization `js` code will be move out of this repo as individual `npm` package plugin. I haven't moved the `deck.gl` directory but could do so after the first round or altogether. Ideally, they should be moved too. This may increase the overhead in development a bit but make them embeddable and keep the main repo lean. 
   
   The backend logic for legacy charts can still live in `viz.py` and be updated in the meantime but no new chart should add logic to `viz.py` and we should gradually reduce the code from this file. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org