You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jakarta.apache.org by sebb <se...@gmail.com> on 2011/09/07 15:35:52 UTC
Re: svn commit: r1166165 - in /jakarta/jmeter/trunk:
src/protocol/http/org/apache/jmeter/protocol/http/control/CacheManager.java xdocs/changes.xml
On 7 September 2011 14:20, <mi...@apache.org> wrote:
> Author: milamber
> Date: Wed Sep 7 13:20:47 2011
> New Revision: 1166165
>
> URL: http://svn.apache.org/viewvc?rev=1166165&view=rev
> Log:
> Bug 51752 - HTTP Cache is broken when using "Retrieve all embedded resources" with concurrent pool
>
> Modified:
> jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/CacheManager.java
> jakarta/jmeter/trunk/xdocs/changes.xml
>
> Modified: jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/CacheManager.java
> URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/CacheManager.java?rev=1166165&r1=1166164&r2=1166165&view=diff
> ==============================================================================
> --- jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/CacheManager.java (original)
> +++ jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/CacheManager.java Wed Sep 7 13:20:47 2011
> @@ -57,7 +57,7 @@ public class CacheManager extends Config
> public static final String USE_EXPIRES = "useExpires"; // $NON-NLS-1$
> //-
>
> - private transient ThreadLocal<Map<String, CacheEntry>> threadCache;
> + private transient InheritableThreadLocal<Map<String, CacheEntry>> threadCache;
Neat fix!
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: dev-help@jakarta.apache.org
Re: svn commit: r1166165 - in /jakarta/jmeter/trunk:
src/protocol/http/org/apache/jmeter/protocol/http/control/CacheManager.java xdocs/changes.xml
Posted by Philippe Mouawad <ph...@gmail.com>.
Hello,
I submitted a patch to 48943.
Regards
Philippe
Re: svn commit: r1166165 - in /jakarta/jmeter/trunk:
src/protocol/http/org/apache/jmeter/protocol/http/control/CacheManager.java xdocs/changes.xml
Posted by sebb <se...@gmail.com>.
On 7 September 2011 14:51, Milamber <mi...@gmail.com> wrote:
> On Wed, Sep 7, 2011 at 1:35 PM, sebb <se...@gmail.com> wrote:
>
>> On 7 September 2011 14:20, <mi...@apache.org> wrote:
>> [snip]
>>
>> - private transient ThreadLocal<Map<String, CacheEntry>> threadCache;
>> > + private transient InheritableThreadLocal<Map<String, CacheEntry>>
>> threadCache;
>>
>> Neat fix!
>>
>
> Thanks.
> 2-3 modified lines, but some hours last sunday to find a elegant way to
> correcting this without success.
Definitely elegant.
> Finally, today I googling, and I discovered this thread:
> http://stackoverflow.com/questions/7259906/propagating-threadlocal-to-a-new-thread-fetched-from-a-executorservice
> (I didn't know this InheritableThreadLocal class before today)
>
Nor me, otherwise I might have thought of using it here.
We need to keep it in mind for any similar situations.
>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail: dev-help@jakarta.apache.org
>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: dev-help@jakarta.apache.org
Re: svn commit: r1166165 - in /jakarta/jmeter/trunk:
src/protocol/http/org/apache/jmeter/protocol/http/control/CacheManager.java xdocs/changes.xml
Posted by Milamber <mi...@gmail.com>.
On Wed, Sep 7, 2011 at 1:35 PM, sebb <se...@gmail.com> wrote:
> On 7 September 2011 14:20, <mi...@apache.org> wrote:
> [snip]
>
> - private transient ThreadLocal<Map<String, CacheEntry>> threadCache;
> > + private transient InheritableThreadLocal<Map<String, CacheEntry>>
> threadCache;
>
> Neat fix!
>
Thanks.
2-3 modified lines, but some hours last sunday to find a elegant way to
correcting this without success.
Finally, today I googling, and I discovered this thread:
http://stackoverflow.com/questions/7259906/propagating-threadlocal-to-a-new-thread-fetched-from-a-executorservice
(I didn't know this InheritableThreadLocal class before today)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: dev-help@jakarta.apache.org
>
>