You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by ti...@apache.org on 2019/08/18 22:18:08 UTC
[maven-archetype] branch release-3.1.2 updated: [ARCHETYPE-578]
Deleted unnecessary calls ".flush()" on I/O streams
This is an automated email from the ASF dual-hosted git repository.
tibordigana pushed a commit to branch release-3.1.2
in repository https://gitbox.apache.org/repos/asf/maven-archetype.git
The following commit(s) were added to refs/heads/release-3.1.2 by this push:
new 010f512 [ARCHETYPE-578] Deleted unnecessary calls ".flush()" on I/O streams
010f512 is described below
commit 010f512d0609ca0c65beb7f08c7f37546eff5ec8
Author: tibordigana <ti...@apache.org>
AuthorDate: Mon Jul 29 09:49:10 2019 +0200
[ARCHETYPE-578] Deleted unnecessary calls ".flush()" on I/O streams
---
.../org/apache/maven/archetype/DefaultArchetypeManager.java | 2 --
.../org/apache/maven/archetype/common/util/XMLOutputter.java | 12 ------------
.../generator/DefaultFilesetArchetypeGenerator.java | 2 --
.../org/apache/maven/archetype/old/DefaultOldArchetype.java | 2 --
.../apache/maven/archetype/mojos/IntegrationTestMojo.java | 1 -
5 files changed, 19 deletions(-)
diff --git a/archetype-common/src/main/java/org/apache/maven/archetype/DefaultArchetypeManager.java b/archetype-common/src/main/java/org/apache/maven/archetype/DefaultArchetypeManager.java
index 4948afc..08062fb 100644
--- a/archetype-common/src/main/java/org/apache/maven/archetype/DefaultArchetypeManager.java
+++ b/archetype-common/src/main/java/org/apache/maven/archetype/DefaultArchetypeManager.java
@@ -152,8 +152,6 @@ public class DefaultArchetypeManager
IOUtil.copy( is, zos );
}
- zos.flush();
-
zos.closeEntry();
}
}
diff --git a/archetype-common/src/main/java/org/apache/maven/archetype/common/util/XMLOutputter.java b/archetype-common/src/main/java/org/apache/maven/archetype/common/util/XMLOutputter.java
index 58e00d1..6b9ca9a 100644
--- a/archetype-common/src/main/java/org/apache/maven/archetype/common/util/XMLOutputter.java
+++ b/archetype-common/src/main/java/org/apache/maven/archetype/common/util/XMLOutputter.java
@@ -437,8 +437,6 @@ public class XMLOutputter
// Output final line separator
// We output this no matter what the newline flags say
out.write( currentFormat.lineSeparator );
-
- out.flush();
}
/**
@@ -451,7 +449,6 @@ public class XMLOutputter
throws IOException
{
printDocType( out, doctype );
- out.flush();
}
/**
@@ -468,7 +465,6 @@ public class XMLOutputter
// If this is the root element we could pre-initialize the
// namespace stack with the namespaces
printElement( out, element, 0, createNamespaceStack() );
- out.flush();
}
/**
@@ -487,7 +483,6 @@ public class XMLOutputter
List<?> content = element.getContent();
printContentRange( out, content, 0, content.size(),
0, createNamespaceStack() );
- out.flush();
}
/**
@@ -503,7 +498,6 @@ public class XMLOutputter
throws IOException
{
printContentRange( out, list, 0, list.size(), 0, createNamespaceStack() );
- out.flush();
}
/**
@@ -516,7 +510,6 @@ public class XMLOutputter
throws IOException
{
printCDATA( out, cdata );
- out.flush();
}
/**
@@ -530,7 +523,6 @@ public class XMLOutputter
throws IOException
{
printText( out, text );
- out.flush();
}
/**
@@ -543,7 +535,6 @@ public class XMLOutputter
throws IOException
{
printComment( out, comment );
- out.flush();
}
/**
@@ -561,8 +552,6 @@ public class XMLOutputter
currentFormat.setIgnoreTrAXEscapingPIs( true );
printProcessingInstruction( out, pi );
currentFormat.setIgnoreTrAXEscapingPIs( currentEscapingPolicy );
-
- out.flush();
}
/**
@@ -575,7 +564,6 @@ public class XMLOutputter
throws IOException
{
printEntityRef( out, entity );
- out.flush();
}
// * * * * * * * * * * Output to a String * * * * * * * * * *
diff --git a/archetype-common/src/main/java/org/apache/maven/archetype/generator/DefaultFilesetArchetypeGenerator.java b/archetype-common/src/main/java/org/apache/maven/archetype/generator/DefaultFilesetArchetypeGenerator.java
index a80767f..b3b4a7d 100644
--- a/archetype-common/src/main/java/org/apache/maven/archetype/generator/DefaultFilesetArchetypeGenerator.java
+++ b/archetype-common/src/main/java/org/apache/maven/archetype/generator/DefaultFilesetArchetypeGenerator.java
@@ -715,8 +715,6 @@ public class DefaultFilesetArchetypeGenerator
velocity.getEngine().mergeTemplate( templateFileName, encoding, context, stringWriter );
writer.write( StringUtils.unifyLineSeparators( stringWriter.toString() ) );
-
- writer.flush();
}
catch ( Exception e )
{
diff --git a/archetype-common/src/main/java/org/apache/maven/archetype/old/DefaultOldArchetype.java b/archetype-common/src/main/java/org/apache/maven/archetype/old/DefaultOldArchetype.java
index 530104f..d235cf4 100644
--- a/archetype-common/src/main/java/org/apache/maven/archetype/old/DefaultOldArchetype.java
+++ b/archetype-common/src/main/java/org/apache/maven/archetype/old/DefaultOldArchetype.java
@@ -759,8 +759,6 @@ public class DefaultOldArchetype
velocity.getEngine().mergeTemplate( template, descriptor.getEncoding(), context, stringWriter );
writer.write( StringUtils.unifyLineSeparators( stringWriter.toString() ) );
-
- writer.flush();
}
catch ( Exception e )
{
diff --git a/maven-archetype-plugin/src/main/java/org/apache/maven/archetype/mojos/IntegrationTestMojo.java b/maven-archetype-plugin/src/main/java/org/apache/maven/archetype/mojos/IntegrationTestMojo.java
index 79d152f..1889d7c 100644
--- a/maven-archetype-plugin/src/main/java/org/apache/maven/archetype/mojos/IntegrationTestMojo.java
+++ b/maven-archetype-plugin/src/main/java/org/apache/maven/archetype/mojos/IntegrationTestMojo.java
@@ -816,7 +816,6 @@ public class IntegrationTestMojo
interpolatedFile.getParentFile().mkdirs();
writer.write( xml );
- writer.flush();
}
}
catch ( IOException e )