You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/04 02:48:40 UTC
[GitHub] [arrow] kou opened a new pull request #8587: ARROW-10490: [C++][GLib] Fix range-loop-analysis warnings
kou opened a new pull request #8587:
URL: https://github.com/apache/arrow/pull/8587
They are detected by Xcode 12.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8587: ARROW-10490: [C++][GLib] Fix range-loop-analysis warnings
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8587:
URL: https://github.com/apache/arrow/pull/8587#issuecomment-721511627
OK.
I'll merge this.
It seems that #8533 isn't related to the JNI failure because #8533 is R related change and the JNI failure is Java related code.
We may need to discuss it at the https://lists.apache.org/thread.html/rdd900f5359fb57f32e3eb686f6584535e81e3b2f7440cbc74f945b67%40%3Cdev.arrow.apache.org%3E thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8587: ARROW-10490: [C++][GLib] Fix range-loop-analysis warnings
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8587:
URL: https://github.com/apache/arrow/pull/8587#issuecomment-721553232
Ah, I see.
> I'll try to follow up on the mailing list tomorrow
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8587: ARROW-10490: [C++][GLib] Fix range-loop-analysis warnings
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8587:
URL: https://github.com/apache/arrow/pull/8587#issuecomment-721485765
https://issues.apache.org/jira/browse/ARROW-10490
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #8587: ARROW-10490: [C++][GLib] Fix range-loop-analysis warnings
Posted by GitBox <gi...@apache.org>.
kou closed pull request #8587:
URL: https://github.com/apache/arrow/pull/8587
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] terencehonles commented on pull request #8587: ARROW-10490: [C++][GLib] Fix range-loop-analysis warnings
Posted by GitBox <gi...@apache.org>.
terencehonles commented on pull request #8587:
URL: https://github.com/apache/arrow/pull/8587#issuecomment-721537038
> OK.
> I'll merge this.
>
> It seems that #8533 isn't related to the JNI failure because #8533 is R related change and the JNI failure is Java related code.
> We may need to discuss it at the https://lists.apache.org/thread.html/rdd900f5359fb57f32e3eb686f6584535e81e3b2f7440cbc74f945b67%40%3Cdev.arrow.apache.org%3E thread.
It's an R related change, but it touches a C file which breaks the java/adapter/orc/src/test/java/org/apache/arrow/adapter/orc/OrcReaderTest.java test (it seems like it's a segfault, but I don't know how to get better logging to confirm that, the process is dead though). Removing the `DCHECK_NE` change in `memory.cc` "fixes" the issue, but it looks like there is also a memory leak coming from java/flight/flight-core/src/test/java/org/apache/arrow/flight/TestDoExchange.java (testClientCancel) which was also causing issues. I'll try to follow up on the mailing list tomorrow (thanks for the heads up about it, I just figured I'd share my findings here)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] terencehonles edited a comment on pull request #8587: ARROW-10490: [C++][GLib] Fix range-loop-analysis warnings
Posted by GitBox <gi...@apache.org>.
terencehonles edited a comment on pull request #8587:
URL: https://github.com/apache/arrow/pull/8587#issuecomment-721537038
> OK.
> I'll merge this.
>
> It seems that #8533 isn't related to the JNI failure because #8533 is R related change and the JNI failure is Java related code.
> We may need to discuss it at the https://lists.apache.org/thread.html/rdd900f5359fb57f32e3eb686f6584535e81e3b2f7440cbc74f945b67%40%3Cdev.arrow.apache.org%3E thread.
It's an R related change, but it touches a C file which breaks the java/adapter/orc/src/test/java/org/apache/arrow/adapter/orc/OrcReaderTest.java test (it seems like it's a segfault, but I don't know how to get better logging to confirm that, the process is dead though). Removing the `DCHECK_NE` change in `memory.cc` "fixes" the issue, but it looks like there is also a memory leak coming from java/flight/flight-core/src/test/java/org/apache/arrow/flight/TestDoExchange.java (testClientCancel) which was also causing tests failures in a different test suite. I'll try to follow up on the mailing list tomorrow (thanks for the heads up about it, I just figured I'd share my findings here)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org