[GitHub] [incubator-superset] eschutho commented on a change in pull request #11207: feat: Added setup for running Cypress tests in docker locally

[GitBox <gi...@apache.org>]

eschutho commented on a change in pull request #11207:
URL: https://github.com/apache/incubator-superset/pull/11207#discussion_r508705809



##########
File path: CONTRIBUTING.md
##########
@@ -608,18 +608,34 @@ We use [Cypress](https://www.cypress.io/) for integration tests. Tests can be ru
 ```bash
 export SUPERSET_CONFIG=tests.superset_test_config
 export CYPRESS_BASE_URL="http://localhost:8081"
+# ENABLE_REACT_CRUD_VIEWS should be enabled for Cypress testing
+sed -i '/ENABLE_REACT_CRUD_VIEWS = False/c\ENABLE_REACT_CRUD_VIEWS = True' superset/config.py
+sed -i '/ENABLE_REACT_CRUD_VIEWS = os.environ.get("ENABLE_REACT_CRUD_VIEWS", False)/c\ENABLE_REACT_CRUD_VIEWS = True' tests/superset_test_config.py

Review comment:
       I don't think we should be updating the user's files. Couldn't we instead just export the value like we do for the CYPRESS_BASE_URL and keep it just for this session?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org