You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "daixiansuo (via GitHub)" <gi...@apache.org> on 2023/03/30 09:22:00 UTC
[GitHub] [rocketmq] daixiansuo opened a new issue, #6511: There are some variables with irregular names in MessageStoreConfig
daixiansuo opened a new issue, #6511:
URL: https://github.com/apache/rocketmq/issues/6511
### Base Info
branch: 4.9.x
RocketMQ Version: 4.9.6-SNAPSHOT
### Description
There are some variables with irregular names in MessageStoreConfig, as follows:
1. destroy**Maped**FileIntervalForcibly ----> destroy**Mapped**FileIntervalForcibly
2. putMsgIndex**Hight**Water ----> putMsgIndex**High**Water
3. flushLeastPagesWhenWarm**Maped**File ----> flushLeastPagesWhenWarm**Mapped**File
4. warm**Maped**FileEnable ----> warm**Mapped**FileEnable
What impact will it bring ?
- broker.conf
- It is itself an incorrect.
Finally, as to whether this issue needs to be corrected, I am willing to participate in it if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] xdkxlk commented on issue #6511: There are some variables with irregular names in MessageStoreConfig
Posted by "xdkxlk (via GitHub)" <gi...@apache.org>.
xdkxlk commented on issue #6511:
URL: https://github.com/apache/rocketmq/issues/6511#issuecomment-1492131869
Maybe we need a function like ＂alias＂ before rename the name of configuration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] daixiansuo commented on issue #6511: There are some variables with irregular names in MessageStoreConfig
Posted by "daixiansuo (via GitHub)" <gi...@apache.org>.
daixiansuo commented on issue #6511:
URL: https://github.com/apache/rocketmq/issues/6511#issuecomment-1498446885
I'm sorry everyone, l was laid off recently to deal with arbitration matters, so l didn't have time to reply.
Regarding this issue, l will close it first, and we can have a brief communication at the weekly community meeting online.
Finally, thank you all for your replies to this question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] daixiansuo closed issue #6511: There are some variables with irregular names in MessageStoreConfig
Posted by "daixiansuo (via GitHub)" <gi...@apache.org>.
daixiansuo closed issue #6511: There are some variables with irregular names in MessageStoreConfig
URL: https://github.com/apache/rocketmq/issues/6511
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] daixiansuo commented on issue #6511: There are some variables with irregular names in MessageStoreConfig
Posted by "daixiansuo (via GitHub)" <gi...@apache.org>.
daixiansuo commented on issue #6511:
URL: https://github.com/apache/rocketmq/issues/6511#issuecomment-1491147351
-----------------
#6512 Reply：’There may be compatibility issues when modify variable name‘
-----------------
Yes, I have also considered this aspect of the problem. However, we will eventually have to face this problem.
At present, it seems that only the broker side is affected, and there are three solutions for this problem:
Leave it alone and keep it as it is.
Direct modification, not compatible with lower versions, please describe the requested modification in the release document.
Compatible with lower versions, you can add a compatible processing interface to the MixAll.properties2Object(p,o) method, which not only solves the current problem, but also achieves mapping and conversion capabilities.
How do we deal with this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhimins commented on issue #6511: There are some variables with irregular names in MessageStoreConfig
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on issue #6511:
URL: https://github.com/apache/rocketmq/issues/6511#issuecomment-1495388901
The abbreviation such as "Msg" is not standardized. Perhaps we can develop a special item on configuration management, where we need to consider compatibility issues between new and old names when deciding on a new name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Sallikrampaudel commented on issue #6511: There are some variables with irregular names in MessageStoreConfig
Posted by "Sallikrampaudel (via GitHub)" <gi...@apache.org>.
Sallikrampaudel commented on issue #6511:
URL: https://github.com/apache/rocketmq/issues/6511#issuecomment-1490696150
Could you please assign this to me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] caigy commented on issue #6511: There are some variables with irregular names in MessageStoreConfig
Posted by "caigy (via GitHub)" <gi...@apache.org>.
caigy commented on issue #6511:
URL: https://github.com/apache/rocketmq/issues/6511#issuecomment-1497308196
> ## #6512 Reply：’There may be compatibility issues when modify variable name‘
> Yes, I have also considered this aspect of the problem. However, we will eventually have to face this problem.
>
> At present, it seems that only the broker side is affected, and there are three solutions for this problem:
>
> 1. Leave it alone and keep it as it is.
> 2. Direct modification, not compatible with earlier versions, please describe the modification clearly in the release document.
> 3. Compatible with lower versions, you can add a compatible processing interface to the MixAll.properties2Object(p,o) method, which not only solves the current problem, but also achieves mapping and conversion capabilities.
>
> How do we deal with this issue?
Maybe we can add new configuration keys and mark those to be replaced as deprecated first, and make a plan to remove them in a future version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org