Re: SolrClient should be immutable?

[Eric Pugh <ep...@apache.org>]

Quick update, there is actually an existing JIRA, SOLR-8975 that was specifically about this issue.

I've closed the current PR, and reopened it as https://github.com/apache/solr/pull/1211, tied to SOLR-8975.   Once I get a LGTM or two, I plan on committing it.  

I'll then go through the list of subtasks on SOLR-8975 and either resolve them as done, or go ahead and do more PR's to get them to done.  

Then I plan on opening a PR for discussion on removing the deprecated methods in main, and potentially in 9x.   



On 2022/11/28 23:39:15 David Smiley wrote:
> On Fri, Nov 25, 2022 at 12:02 PM Eric Pugh <ep...@apache.org> wrote:
> 
> >
> > Once this is in, I'd like to tackle removing the deprecated methods on our
> > various SolrClients, and if we can get that done, then those classes will
> > be a lot shorter and easier to read.  Is removing the deprecated methods
> > something that can only happen on main?
> >
> >
> If a method was deprecated *prior* to 9.0 (e.g. in 8.11) then we are free
> to remove it in 9 and beyond at any time.  If it was only deprecated in 9.0
> then it could be inconsiderate/surprising so we should strongly avoid
> that, particularly for things a user is likely to call.
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
For additional commands, e-mail: dev-help@solr.apache.org