You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "klevy-toast (via GitHub)" <gi...@apache.org> on 2023/02/10 20:11:29 UTC
[GitHub] [pulsar] klevy-toast opened a new pull request, #19486: [improve][java client] Remove default 30s ackTimeout when setting DLQ policy on java consumer
klevy-toast opened a new pull request, #19486:
URL: https://github.com/apache/pulsar/pull/19486
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
-->
<!-- Either this PR fixes an issue, -->
Fixes #19134
<!-- Details of when a PIP is required and how the PIP process work, please see: https://github.com/apache/pulsar/blob/master/wiki/proposals/PIP.md -->
### Motivation
The java client automatically sets a 30s `ackTimeout` when a `deadLetterPolicy` is configured. This behavior was added before there was any ability to `negativeAcknowledge`. Now that `negativeAcknowledge` exists, it is unnecessary. Furthermore, it is confusing and inconsistent - more details in the issue.
### Modifications
Removed setting `ackTimeoutMillis` in java `ConsumerBuilder` when a `deadLetterPolicy` is set.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is already covered by existing tests, such as *ConsumerBuilderImplTest*.
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [x] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #19486: [improve][client] Remove default 30s ackTimeout when setting DLQ policy on java consumer
Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall commented on PR #19486:
URL: https://github.com/apache/pulsar/pull/19486#issuecomment-1557680147
@GerMoranOverstock - yes, that Javadoc should be updated in light of this PR. Are you interested in contributing the PR to remove those lines?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #19486: [improve][client] Remove default 30s ackTimeout when setting DLQ policy on java consumer
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #19486:
URL: https://github.com/apache/pulsar/pull/19486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] GerMoranOverstock commented on pull request #19486: [improve][client] Remove default 30s ackTimeout when setting DLQ policy on java consumer
Posted by "GerMoranOverstock (via GitHub)" <gi...@apache.org>.
GerMoranOverstock commented on PR #19486:
URL: https://github.com/apache/pulsar/pull/19486#issuecomment-1557079438
ConsumerBuilder still has the following javadoc
```
By default, the acknowledgment timeout is disabled (set to `0`, which means infinite). When a consumer with an infinite acknowledgment timeout terminates, any unacknowledged messages that it receives are re-delivered to another consumer.
Since 2.3.0, when a dead letter policy is specified and no ackTimeoutMillis is specified, the acknowledgment timeout is set to 30 seconds.
```
I presume this is no longer applicable given these changes, so should be removed as well.
Can this be confirmed before I write a ticket/PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #19486: [improve][client] Remove default 30s ackTimeout when setting DLQ policy on java consumer
Posted by "codelipenghui (via GitHub)" <gi...@apache.org>.
codelipenghui commented on PR #19486:
URL: https://github.com/apache/pulsar/pull/19486#issuecomment-1429099404
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #19486: [improve][java client] Remove default 30s ackTimeout when setting DLQ policy on java consumer
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19486:
URL: https://github.com/apache/pulsar/pull/19486#issuecomment-1426286990
@klevy-toast Please select only one documentation label in your PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] GerMoranOverstock commented on pull request #19486: [improve][client] Remove default 30s ackTimeout when setting DLQ policy on java consumer
Posted by "GerMoranOverstock (via GitHub)" <gi...@apache.org>.
GerMoranOverstock commented on PR #19486:
URL: https://github.com/apache/pulsar/pull/19486#issuecomment-1558801321
> @GerMoranOverstock - yes, that Javadoc should be updated in light of this PR. Are you interested in contributing the PR to remove those lines?
Can do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org