You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2017/11/12 05:45:32 UTC

[GitHub] mistercrunch closed pull request #3837: [Dashboard bug] should reset chartAlert when start new query

mistercrunch closed pull request #3837: [Dashboard bug] should reset chartAlert when start new query
URL: https://github.com/apache/incubator-superset/pull/3837
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/assets/javascripts/chart/chartReducer.js b/superset/assets/javascripts/chart/chartReducer.js
index 7d5b23c32f..c67d66210a 100644
--- a/superset/assets/javascripts/chart/chartReducer.js
+++ b/superset/assets/javascripts/chart/chartReducer.js
@@ -41,6 +41,7 @@ export default function chartReducer(charts = {}, action) {
     [actions.CHART_UPDATE_STARTED](state) {
       return { ...state,
         chartStatus: 'loading',
+        chartAlert: null,
         chartUpdateEndTime: null,
         chartUpdateStartTime: now(),
         queryRequest: action.queryRequest,


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services