You are viewing a plain text version of this content. The canonical link for it is here.
Posted to proton@qpid.apache.org by dcristoloveanu <gi...@git.apache.org> on 2015/04/29 23:29:31 UTC
[GitHub] qpid-proton pull request: Initial transport frame size 256 bytes
GitHub user dcristoloveanu opened a pull request:
https://github.com/apache/qpid-proton/pull/25
Initial transport frame size 256 bytes
In order to reduce RAM footprint on rather simple scenarios on small devices the initial transport frame size could be lowered to 256, since the buffer is anyhow automatically enlarged if needed.
Per earlier suggestions I created a config.h where parameters like this can go (the next candidate is the initial size for pn_data). If the need arises these parameters should be easily changeable in this case to match the platform need.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dcristoloveanu/qpid-proton RAM-Transport-Frame-256-bytes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-proton/pull/25.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #25
----
commit 2158ef3447bab718cfa7b1cb9f9c635cb83beb7f
Author: dcristoloveanu <dc...@microsoft.com>
Date: 2015-04-28T21:01:49Z
Add config.h
commit 65c6ce3df2c1c531cce49d2c3aab5f79f59c63bb
Author: dcristoloveanu <dc...@microsoft.com>
Date: 2015-04-29T21:21:31Z
-Added a configuration file named config.h where various parameters should be configurable (like transport initial frame buffer size, pnin the future _data initial size, etc.)
-Set initial transport frame buffer size to 256 instead of 4K
-Added config.h to the cmakelists.txt so that it shows up also in the Proton.sln Windows solution
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] qpid-proton pull request: Initial transport frame size 256 bytes
Posted by dcristoloveanu <gi...@git.apache.org>.
Github user dcristoloveanu commented on the pull request:
https://github.com/apache/qpid-proton/pull/25#issuecomment-99319844
Friendly ping ...
Thanks,
/Dan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] qpid-proton pull request: Initial transport frame size 256 bytes
Posted by dnwe <gi...@git.apache.org>.
Github user dnwe commented on the pull request:
https://github.com/apache/qpid-proton/pull/25#issuecomment-100819482
@dcristoloveanu you don't appear to have pushed the updated commits for this PR - could you also `git pull --rebase` from master and then squash into a single commit with the updates
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] qpid-proton pull request: Initial transport frame size 256 bytes
Posted by dnwe <gi...@git.apache.org>.
Github user dnwe commented on the pull request:
https://github.com/apache/qpid-proton/pull/25#issuecomment-99389116
@dcristoloveanu couple of buddycheck comments
1. the include guard `CONFIG_H` is a bit generic, perhaps change to `_PROTON_SRC_CONFIG_H`
2. would 512 be a better default as it would match [MIX-MAX-FRAME-SIZE](http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#definition-MIN-MAX-FRAME-SIZE)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] qpid-proton pull request: Initial transport frame size 256 bytes
Posted by dcristoloveanu <gi...@git.apache.org>.
Github user dcristoloveanu commented on the pull request:
https://github.com/apache/qpid-proton/pull/25#issuecomment-100987919
@dnwe Sorry about that, I updated the branch to have only on commit.
Thanks,
/Dan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] qpid-proton pull request: Initial transport frame size 256 bytes
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/qpid-proton/pull/25
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] qpid-proton pull request: Initial transport frame size 256 bytes
Posted by dcristoloveanu <gi...@git.apache.org>.
Github user dcristoloveanu commented on the pull request:
https://github.com/apache/qpid-proton/pull/25#issuecomment-100291491
@dnwe
1.Sure, updated
2.Changed to 512.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---