[GitHub] [arrow-datafusion] alamb commented on pull request #7150: Minor: consolidate `GroupByOrderMode::None`

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on PR #7150:
URL: https://github.com/apache/arrow-datafusion/pull/7150#issuecomment-1660127551

   >  I think we could have pursued, this approach. Do you think that this is not a good change?
   
   Sorry I should have been more explicit. Basically I closed it because
   
   1. It was going to conflict with https://github.com/apache/arrow-datafusion/pull/7129
   2. While I prefer this approach rather than `Option` I think that was just a personal preference and I don't think there is any technical reason to prefer Option vs this.
   3. I was running out of time yesterday and was feeling overwhelmed by too many other open threads of thought to pursue this one
   
   So I do think it is a good change but not valuable enough that I plan to pursue at this time
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org