You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/04/05 07:42:03 UTC
[GitHub] [arrow] kou commented on a diff in pull request #34844: GH-34843: [R] Fix R build failed caused by Acero refactor
kou commented on code in PR #34844:
URL: https://github.com/apache/arrow/pull/34844#discussion_r1158133638
##########
dev/tasks/homebrew-formulae/apache-arrow.rb:
##########
@@ -72,6 +72,7 @@ def install
# link against system libc++ instead of llvm provided libc++
ENV.remove "HOMEBREW_LIBRARY_PATHS", Formula["llvm"].opt_lib
args = %W[
+ -DARROW_ACERO=ON
Review Comment:
Do we need this?
`ARROW_DATASET=ON` must enable `ARROW_ACERO` automatically: https://github.com/apache/arrow/blob/ee42b908f5102fe8c73b5e84b58b155e49ada747/cpp/cmake_modules/DefineOptions.cmake#L308-L313
##########
r/inst/build_arrow_static.sh:
##########
@@ -55,6 +55,7 @@ ${CMAKE} -DARROW_BOOST_USE_SHARED=OFF \
-DARROW_BUILD_TESTS=OFF \
-DARROW_BUILD_SHARED=OFF \
-DARROW_BUILD_STATIC=ON \
+ -DARROW_ACERO=${ARROW_ACERO:-$ARROW_DEFAULT_PARAM} \
Review Comment:
How about using `ON` as the default value because `ARROW_DATASET` uses `ON` as the default value?
```suggestion
-DARROW_ACERO=${ARROW_ACERO:-ON} \
```
##########
dev/tasks/homebrew-formulae/autobrew/apache-arrow.rb:
##########
@@ -44,6 +44,7 @@ def install
args = %W[
-DARROW_BUILD_SHARED=OFF
-DARROW_BUILD_UTILITIES=ON
+ -DARROW_ACERO=ON
Review Comment:
ditto.
##########
r/tools/autobrew:
##########
@@ -62,7 +62,7 @@ fi
# Hardcode this for my custom autobrew build
rm -f $BREWDIR/lib/*.dylib
AWS_LIBS="-laws-cpp-sdk-config -laws-cpp-sdk-transfer -laws-cpp-sdk-identity-management -laws-cpp-sdk-cognito-identity -laws-cpp-sdk-sts -laws-cpp-sdk-s3 -laws-cpp-sdk-core -laws-c-event-stream -laws-checksums -laws-c-common -laws-crt-cpp -laws-c-io -laws-c-s3 -laws-c-auth -laws-c-http -laws-c-cal -laws-c-compression -laws-c-mqtt -lpthread -lcurl"
-PKG_LIBS="-lparquet -larrow_dataset -larrow -larrow_bundled_dependencies -lthrift -lbrotlienc-static -lbrotlidec-static -lbrotlicommon-static -llz4 -lsnappy -lzstd $AWS_LIBS"
+PKG_LIBS="-lparquet -larrow_dataset -larrow_acero -larrow -larrow_bundled_dependencies -lthrift -lbrotlienc-static -lbrotlidec-static -lbrotlicommon-static -llz4 -lsnappy -lzstd $AWS_LIBS"
Review Comment:
```suggestion
PKG_LIBS="-larrow_dataset -larrow_acero -lparquet -larrow -larrow_bundled_dependencies -lthrift -lbrotlienc-static -lbrotlidec-static -lbrotlicommon-static -llz4 -lsnappy -lzstd $AWS_LIBS"
```
##########
dev/tasks/homebrew-formulae/autobrew/apache-arrow-static.rb:
##########
@@ -53,6 +53,7 @@ def install
args = %W[
-DARROW_BUILD_SHARED=OFF
-DARROW_BUILD_UTILITIES=ON
+ -DARROW_ACERO=ON
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org