You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2008/08/22 02:40:44 UTC
[jira] Created: (THRIFT-121) Add support for type modifiers
Add support for type modifiers
------------------------------
Key: THRIFT-121
URL: https://issues.apache.org/jira/browse/THRIFT-121
Project: Thrift
Issue Type: New Feature
Components: Compiler (General)
Reporter: Bryan Duxbury
We'd like to have the ability to add type modifiers in the IDL to help protocols decide what encodings can be used for certain types. Some examples would be "fixed" and "zigzag" for integer types, and "extern" for strings (and possibly binary?) types.
In addition to modifying the parser to properly detect type modifiers, we must change the signature of some protocol methods in all protocols to take a new parameter containing the type modifier. Implementations are free to act on or ignore the modifier accordingly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-121) Add support for type modifiers
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649484#action_12649484 ]
Bryan Duxbury commented on THRIFT-121:
--------------------------------------
This looks really interesting. What's keeping this from being committed?
Do struct fields support modifiers as well?
> Add support for type modifiers
> ------------------------------
>
> Key: THRIFT-121
> URL: https://issues.apache.org/jira/browse/THRIFT-121
> Project: Thrift
> Issue Type: New Feature
> Components: Compiler (General)
> Reporter: Bryan Duxbury
>
> We'd like to have the ability to add type modifiers in the IDL to help protocols decide what encodings can be used for certain types. Some examples would be "fixed" and "zigzag" for integer types, and "extern" for strings (and possibly binary?) types.
> In addition to modifying the parser to properly detect type modifiers, we must change the signature of some protocol methods in all protocols to take a new parameter containing the type modifier. Implementations are free to act on or ignore the modifier accordingly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-121) Add support for type modifiers
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss resolved THRIFT-121.
--------------------------------
Resolution: Fixed
> Add support for type modifiers
> ------------------------------
>
> Key: THRIFT-121
> URL: https://issues.apache.org/jira/browse/THRIFT-121
> Project: Thrift
> Issue Type: New Feature
> Components: Compiler (General)
> Reporter: Bryan Duxbury
>
> We'd like to have the ability to add type modifiers in the IDL to help protocols decide what encodings can be used for certain types. Some examples would be "fixed" and "zigzag" for integer types, and "extern" for strings (and possibly binary?) types.
> In addition to modifying the parser to properly detect type modifiers, we must change the signature of some protocol methods in all protocols to take a new parameter containing the type modifier. Implementations are free to act on or ignore the modifier accordingly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-121) Add support for type modifiers
Posted by "Erik Frey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641352#action_12641352 ]
Erik Frey commented on THRIFT-121:
----------------------------------
This is great - I'd be happy to submit patches for a final type modifier once this is ready for svn.
> Add support for type modifiers
> ------------------------------
>
> Key: THRIFT-121
> URL: https://issues.apache.org/jira/browse/THRIFT-121
> Project: Thrift
> Issue Type: New Feature
> Components: Compiler (General)
> Reporter: Bryan Duxbury
>
> We'd like to have the ability to add type modifiers in the IDL to help protocols decide what encodings can be used for certain types. Some examples would be "fixed" and "zigzag" for integer types, and "extern" for strings (and possibly binary?) types.
> In addition to modifying the parser to properly detect type modifiers, we must change the signature of some protocol methods in all protocols to take a new parameter containing the type modifier. Implementations are free to act on or ignore the modifier accordingly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-121) Add support for type modifiers
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss updated THRIFT-121:
-------------------------------
Patch Info: [Patch Available]
Initial implementation: http://gitweb.thrift-rpc.org/?p=thrift.git;a=commitdiff;h=7519a92
Hacky test: http://gitweb.thrift-rpc.org/?p=thrift.git;a=commitdiff;h=665820d
> Add support for type modifiers
> ------------------------------
>
> Key: THRIFT-121
> URL: https://issues.apache.org/jira/browse/THRIFT-121
> Project: Thrift
> Issue Type: New Feature
> Components: Compiler (General)
> Reporter: Bryan Duxbury
>
> We'd like to have the ability to add type modifiers in the IDL to help protocols decide what encodings can be used for certain types. Some examples would be "fixed" and "zigzag" for integer types, and "extern" for strings (and possibly binary?) types.
> In addition to modifying the parser to properly detect type modifiers, we must change the signature of some protocol methods in all protocols to take a new parameter containing the type modifier. Implementations are free to act on or ignore the modifier accordingly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-121) Add support for type modifiers
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649487#action_12649487 ]
David Reiss commented on THRIFT-121:
------------------------------------
I'm fine with committing it as long as someone reviews the code.
This version does not support annotations on structure fields.
> Add support for type modifiers
> ------------------------------
>
> Key: THRIFT-121
> URL: https://issues.apache.org/jira/browse/THRIFT-121
> Project: Thrift
> Issue Type: New Feature
> Components: Compiler (General)
> Reporter: Bryan Duxbury
>
> We'd like to have the ability to add type modifiers in the IDL to help protocols decide what encodings can be used for certain types. Some examples would be "fixed" and "zigzag" for integer types, and "extern" for strings (and possibly binary?) types.
> In addition to modifying the parser to properly detect type modifiers, we must change the signature of some protocol methods in all protocols to take a new parameter containing the type modifier. Implementations are free to act on or ignore the modifier accordingly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-121) Add support for type modifiers
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654247#action_12654247 ]
Bryan Duxbury commented on THRIFT-121:
--------------------------------------
I looked at the diff. It looks very simple. I think you should commit this so other related issues can start to benefit. We can explore annotating individual fields later.
> Add support for type modifiers
> ------------------------------
>
> Key: THRIFT-121
> URL: https://issues.apache.org/jira/browse/THRIFT-121
> Project: Thrift
> Issue Type: New Feature
> Components: Compiler (General)
> Reporter: Bryan Duxbury
>
> We'd like to have the ability to add type modifiers in the IDL to help protocols decide what encodings can be used for certain types. Some examples would be "fixed" and "zigzag" for integer types, and "extern" for strings (and possibly binary?) types.
> In addition to modifying the parser to properly detect type modifiers, we must change the signature of some protocol methods in all protocols to take a new parameter containing the type modifier. Implementations are free to act on or ignore the modifier accordingly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-121) Add support for type modifiers
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641176#action_12641176 ]
David Reiss commented on THRIFT-121:
------------------------------------
I'd like to eventually see this replace cpp_type, all of the xsd_ attributes, and Erlang's slist.
> Add support for type modifiers
> ------------------------------
>
> Key: THRIFT-121
> URL: https://issues.apache.org/jira/browse/THRIFT-121
> Project: Thrift
> Issue Type: New Feature
> Components: Compiler (General)
> Reporter: Bryan Duxbury
>
> We'd like to have the ability to add type modifiers in the IDL to help protocols decide what encodings can be used for certain types. Some examples would be "fixed" and "zigzag" for integer types, and "extern" for strings (and possibly binary?) types.
> In addition to modifying the parser to properly detect type modifiers, we must change the signature of some protocol methods in all protocols to take a new parameter containing the type modifier. Implementations are free to act on or ignore the modifier accordingly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.