You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pdfbox.apache.org by "Adam Nichols (JIRA)" <ji...@apache.org> on 2010/07/16 19:44:54 UTC
[jira] Created: (PDFBOX-777) Add utility class to easily extract a
range of pages from a PDF
Add utility class to easily extract a range of pages from a PDF
---------------------------------------------------------------
Key: PDFBOX-777
URL: https://issues.apache.org/jira/browse/PDFBOX-777
Project: PDFBox
Issue Type: New Feature
Components: Utilities
Reporter: Adam Nichols
Assignee: Adam Nichols
Fix For: 1.3.0
There's currently no utility to extract a range of pages (e.g. pages 3-7). This task adds a PageExtractor class and a corresponding JUnit test class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PDFBOX-777) Add utility class to easily extract
a range of pages from a PDF
Posted by "Andreas Lehmkühler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PDFBOX-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889498#action_12889498 ]
Andreas Lehmkühler commented on PDFBOX-777:
-------------------------------------------
I agree with Jukka and I'd like to add one more thing. At least all public methods/variables should have a javadoc comment even the getters/setters.
> Add utility class to easily extract a range of pages from a PDF
> ---------------------------------------------------------------
>
> Key: PDFBOX-777
> URL: https://issues.apache.org/jira/browse/PDFBOX-777
> Project: PDFBox
> Issue Type: New Feature
> Components: Utilities
> Reporter: Adam Nichols
> Assignee: Adam Nichols
> Fix For: 1.3.0
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There's currently no utility to extract a range of pages (e.g. pages 3-7). This task adds a PageExtractor class and a corresponding JUnit test class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PDFBOX-777) Add utility class to easily extract
a range of pages from a PDF
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PDFBOX-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889496#action_12889496 ]
Jukka Zitting commented on PDFBOX-777:
--------------------------------------
Looks good to me.
You may want to avoid using System.out prints and Exception.printStackTrace() in the test case. A better alternative is usually to use JUnit assertions that print out the message or the exception only when something unexpected happens.
There's also a general preference at Apache to avoid adding @author tags to Java code since over time each file will most likely end up being revised by many different authors. A better record of the authors of a given file can be seen in the svn log. However, the PDFBox codebase has historically contained lots of @author tags and we haven't really discussed whether we want to keep adding/updating them or not, so either way is fine.
> Add utility class to easily extract a range of pages from a PDF
> ---------------------------------------------------------------
>
> Key: PDFBOX-777
> URL: https://issues.apache.org/jira/browse/PDFBOX-777
> Project: PDFBox
> Issue Type: New Feature
> Components: Utilities
> Reporter: Adam Nichols
> Assignee: Adam Nichols
> Fix For: 1.3.0
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There's currently no utility to extract a range of pages (e.g. pages 3-7). This task adds a PageExtractor class and a corresponding JUnit test class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PDFBOX-777) Add utility class to easily extract
a range of pages from a PDF
Posted by "Adam Nichols (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PDFBOX-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890074#action_12890074 ]
Adam Nichols commented on PDFBOX-777:
-------------------------------------
Thank you for the feedback. I removed System.out, removed printStackTrace(), and added JavaDoc to accessors.
> Add utility class to easily extract a range of pages from a PDF
> ---------------------------------------------------------------
>
> Key: PDFBOX-777
> URL: https://issues.apache.org/jira/browse/PDFBOX-777
> Project: PDFBox
> Issue Type: New Feature
> Components: Utilities
> Reporter: Adam Nichols
> Assignee: Adam Nichols
> Fix For: 1.3.0
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There's currently no utility to extract a range of pages (e.g. pages 3-7). This task adds a PageExtractor class and a corresponding JUnit test class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (PDFBOX-777) Add utility class to easily extract a
range of pages from a PDF
Posted by "Adam Nichols (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PDFBOX-777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Nichols resolved PDFBOX-777.
---------------------------------
Resolution: Fixed
> Add utility class to easily extract a range of pages from a PDF
> ---------------------------------------------------------------
>
> Key: PDFBOX-777
> URL: https://issues.apache.org/jira/browse/PDFBOX-777
> Project: PDFBox
> Issue Type: New Feature
> Components: Utilities
> Reporter: Adam Nichols
> Assignee: Adam Nichols
> Fix For: 1.3.0
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There's currently no utility to extract a range of pages (e.g. pages 3-7). This task adds a PageExtractor class and a corresponding JUnit test class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (PDFBOX-777) Add utility class to
easily extract a range of pages from a PDF
Posted by "Adam Nichols (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PDFBOX-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889245#action_12889245 ]
Adam Nichols edited comment on PDFBOX-777 at 7/16/10 2:53 PM:
--------------------------------------------------------------
Committed in 964902. If someone could take a couple minutes to look over the files and make sure everything is proper (license info, that it's acceptable to use Generics, etc.) I would appreciate it.
I went with the standard Java code formatting for these files, as this is what we're moving towards, as discussed on the dev mailing list.
was (Author: adamnichols):
Committed in 964886. If someone could take a couple minutes to look over the files and make sure everything is proper (license info, that it's acceptable to use Generics, etc.) I would appreciate it.
I went with the standard Java code formatting for these files, as this is what we're moving towards, as discussed on the dev mailing list.
> Add utility class to easily extract a range of pages from a PDF
> ---------------------------------------------------------------
>
> Key: PDFBOX-777
> URL: https://issues.apache.org/jira/browse/PDFBOX-777
> Project: PDFBox
> Issue Type: New Feature
> Components: Utilities
> Reporter: Adam Nichols
> Assignee: Adam Nichols
> Fix For: 1.3.0
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There's currently no utility to extract a range of pages (e.g. pages 3-7). This task adds a PageExtractor class and a corresponding JUnit test class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PDFBOX-777) Add utility class to easily extract
a range of pages from a PDF
Posted by "Adam Nichols (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PDFBOX-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889245#action_12889245 ]
Adam Nichols commented on PDFBOX-777:
-------------------------------------
Committed in 964886. If someone could take a couple minutes to look over the files and make sure everything is proper (license info, that it's acceptable to use Generics, etc.) I would appreciate it.
I went with the standard Java code formatting for these files, as this is what we're moving towards, as discussed on the dev mailing list.
> Add utility class to easily extract a range of pages from a PDF
> ---------------------------------------------------------------
>
> Key: PDFBOX-777
> URL: https://issues.apache.org/jira/browse/PDFBOX-777
> Project: PDFBox
> Issue Type: New Feature
> Components: Utilities
> Reporter: Adam Nichols
> Assignee: Adam Nichols
> Fix For: 1.3.0
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There's currently no utility to extract a range of pages (e.g. pages 3-7). This task adds a PageExtractor class and a corresponding JUnit test class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.