[GitHub] [spark] cloud-fan commented on a change in pull request #35273: [SPARK-37983][SQL] Back out agg build time metrics from sort aggregate

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #35273:
URL: https://github.com/apache/spark/pull/35273#discussion_r791325928



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/SortAggregateExec.scala
##########
@@ -44,8 +42,7 @@ case class SortAggregateExec(
   with AliasAwareOutputOrdering {
 
   override lazy val metrics = Map(
-    "numOutputRows" -> SQLMetrics.createMetric(sparkContext, "number of output rows"),
-    "aggTime" -> SQLMetrics.createTimingMetric(sparkContext, "time in aggregation build"))

Review comment:
       unrelated to this PR: the name `aggTime` is a bit misleading. Is it actually the time to build the hash table?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org