You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "git-hulk (via GitHub)" <gi...@apache.org> on 2023/07/18 05:03:04 UTC

[GitHub] [kvrocks-website] git-hulk commented on a diff in pull request #134: Refresh the INFO page to add missing fields

git-hulk commented on code in PR #134:
URL: https://github.com/apache/kvrocks-website/pull/134#discussion_r1266224997


##########
docs/info-sections.md:
##########
@@ -272,18 +340,25 @@ There are five column families on kvrocks:
 |---------------|------------------------------------------------------------------------------------------------------------|
 | default       | Used to store the subkeys of the complex data structure like hash/set/list/zset/geo.                       |
 | metadata      | Used to store the metadata of the complex data structure and string.                                       |
-| zset score    | Used to store the mapping of zset's score to member, which would make the range by score operation faster. |
+| zset_score    | Used to store the mapping of zset's score to member, which would make the range by score operation faster. |
 | pubsub        | Used to propagate the pubsub message to replicas.                                                          |
 | propagate     | Used to propagate other commands to replicas except pubsub message.                                        |
+| stream        | xxx.                                        |
 
 ... and below statistics were column family related:
 
-| Property                      | Desc                                                                                                                                                         |
-|-------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| estimate_keys[xxx]            | Estimate keys in the column family, may contains the tombstone and expired keys, it's a fast way to know how many keys on the column family but not precise. |
-| block_cache_usage[xxx]        | Total block cache bytes used by this column family.                                                                                                          |
-| block_cache_pinned_usage[xxx] | Total pinned bytes in this column family.                                                                                                                    |
-| index_and_filter_cache_usage  | Total bytes was used to cache the index and filter block.                                                                                                    |
+| Property                                | Desc                                                                                                                                                         |
+|-----------------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| estimate_keys[xxx]                      | Estimate keys in the column family, may contains the tombstone and expired keys, it's a fast way to know how many keys on the column family but not precise. |
+| block_cache_usage[xxx]                  | Total block cache bytes used by this column family.                                                                                                          |
+| block_cache_pinned_usage[xxx]           | Total pinned bytes in this column family.                                                                                                                    |
+| index_and_filter_cache_usage[xxx]       | Total bytes was used to cache the index and filter block.                                                                                                    |
+| level0_file_limit_slowdown[xxx]         | xxx.                                                                                                    |
+| level0_file_limit_stop[xxx]             | xxx.                                                                                                    |

Review Comment:
   ```suggestion
   | level0_file_limit_stop[xxx]             | Number of IO write stalls caused by reaching the level0 file stop limit.                                                                                                |
   ```



##########
docs/info-sections.md:
##########
@@ -272,18 +340,25 @@ There are five column families on kvrocks:
 |---------------|------------------------------------------------------------------------------------------------------------|
 | default       | Used to store the subkeys of the complex data structure like hash/set/list/zset/geo.                       |
 | metadata      | Used to store the metadata of the complex data structure and string.                                       |
-| zset score    | Used to store the mapping of zset's score to member, which would make the range by score operation faster. |
+| zset_score    | Used to store the mapping of zset's score to member, which would make the range by score operation faster. |
 | pubsub        | Used to propagate the pubsub message to replicas.                                                          |
 | propagate     | Used to propagate other commands to replicas except pubsub message.                                        |
+| stream        | xxx.                                        |
 
 ... and below statistics were column family related:
 
-| Property                      | Desc                                                                                                                                                         |
-|-------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| estimate_keys[xxx]            | Estimate keys in the column family, may contains the tombstone and expired keys, it's a fast way to know how many keys on the column family but not precise. |
-| block_cache_usage[xxx]        | Total block cache bytes used by this column family.                                                                                                          |
-| block_cache_pinned_usage[xxx] | Total pinned bytes in this column family.                                                                                                                    |
-| index_and_filter_cache_usage  | Total bytes was used to cache the index and filter block.                                                                                                    |
+| Property                                | Desc                                                                                                                                                         |
+|-----------------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| estimate_keys[xxx]                      | Estimate keys in the column family, may contains the tombstone and expired keys, it's a fast way to know how many keys on the column family but not precise. |
+| block_cache_usage[xxx]                  | Total block cache bytes used by this column family.                                                                                                          |
+| block_cache_pinned_usage[xxx]           | Total pinned bytes in this column family.                                                                                                                    |
+| index_and_filter_cache_usage[xxx]       | Total bytes was used to cache the index and filter block.                                                                                                    |
+| level0_file_limit_slowdown[xxx]         | xxx.                                                                                                    |
+| level0_file_limit_stop[xxx]             | xxx.                                                                                                    |
+| pending_compaction_bytes_slowdown[xxx]  | xxx.                                                                                                    |
+| pending_compaction_bytes_stop[xxx]      | xxx.                                                                                                    |

Review Comment:
   ```suggestion
   | pending_compaction_bytes_stop[xxx]      | Number of IO write stalls caused reaching the pending compaction bytes stop limit.                                                                                                    |
   ```



##########
docs/info-sections.md:
##########
@@ -272,18 +340,25 @@ There are five column families on kvrocks:
 |---------------|------------------------------------------------------------------------------------------------------------|
 | default       | Used to store the subkeys of the complex data structure like hash/set/list/zset/geo.                       |
 | metadata      | Used to store the metadata of the complex data structure and string.                                       |
-| zset score    | Used to store the mapping of zset's score to member, which would make the range by score operation faster. |
+| zset_score    | Used to store the mapping of zset's score to member, which would make the range by score operation faster. |
 | pubsub        | Used to propagate the pubsub message to replicas.                                                          |
 | propagate     | Used to propagate other commands to replicas except pubsub message.                                        |
+| stream        | xxx.                                        |
 
 ... and below statistics were column family related:
 
-| Property                      | Desc                                                                                                                                                         |
-|-------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| estimate_keys[xxx]            | Estimate keys in the column family, may contains the tombstone and expired keys, it's a fast way to know how many keys on the column family but not precise. |
-| block_cache_usage[xxx]        | Total block cache bytes used by this column family.                                                                                                          |
-| block_cache_pinned_usage[xxx] | Total pinned bytes in this column family.                                                                                                                    |
-| index_and_filter_cache_usage  | Total bytes was used to cache the index and filter block.                                                                                                    |
+| Property                                | Desc                                                                                                                                                         |
+|-----------------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| estimate_keys[xxx]                      | Estimate keys in the column family, may contains the tombstone and expired keys, it's a fast way to know how many keys on the column family but not precise. |
+| block_cache_usage[xxx]                  | Total block cache bytes used by this column family.                                                                                                          |
+| block_cache_pinned_usage[xxx]           | Total pinned bytes in this column family.                                                                                                                    |
+| index_and_filter_cache_usage[xxx]       | Total bytes was used to cache the index and filter block.                                                                                                    |
+| level0_file_limit_slowdown[xxx]         | xxx.                                                                                                    |
+| level0_file_limit_stop[xxx]             | xxx.                                                                                                    |
+| pending_compaction_bytes_slowdown[xxx]  | xxx.                                                                                                    |
+| pending_compaction_bytes_stop[xxx]      | xxx.                                                                                                    |
+| memtable_count_limit_slowdown[xxx]      | xxx.                                                                                                    |
+| memtable_count_limit_stop[xxx]          | xxx.                                                                                                    |

Review Comment:
   ```suggestion
   | memtable_count_limit_stop[xxx]          | Number of IO write stalls caused by reaching the memtable count stop limit.                                                                                                  |
   ```



##########
docs/info-sections.md:
##########
@@ -272,18 +340,25 @@ There are five column families on kvrocks:
 |---------------|------------------------------------------------------------------------------------------------------------|
 | default       | Used to store the subkeys of the complex data structure like hash/set/list/zset/geo.                       |
 | metadata      | Used to store the metadata of the complex data structure and string.                                       |
-| zset score    | Used to store the mapping of zset's score to member, which would make the range by score operation faster. |
+| zset_score    | Used to store the mapping of zset's score to member, which would make the range by score operation faster. |
 | pubsub        | Used to propagate the pubsub message to replicas.                                                          |
 | propagate     | Used to propagate other commands to replicas except pubsub message.                                        |
+| stream        | xxx.                                        |
 
 ... and below statistics were column family related:
 
-| Property                      | Desc                                                                                                                                                         |
-|-------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| estimate_keys[xxx]            | Estimate keys in the column family, may contains the tombstone and expired keys, it's a fast way to know how many keys on the column family but not precise. |
-| block_cache_usage[xxx]        | Total block cache bytes used by this column family.                                                                                                          |
-| block_cache_pinned_usage[xxx] | Total pinned bytes in this column family.                                                                                                                    |
-| index_and_filter_cache_usage  | Total bytes was used to cache the index and filter block.                                                                                                    |
+| Property                                | Desc                                                                                                                                                         |
+|-----------------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| estimate_keys[xxx]                      | Estimate keys in the column family, may contains the tombstone and expired keys, it's a fast way to know how many keys on the column family but not precise. |
+| block_cache_usage[xxx]                  | Total block cache bytes used by this column family.                                                                                                          |
+| block_cache_pinned_usage[xxx]           | Total pinned bytes in this column family.                                                                                                                    |
+| index_and_filter_cache_usage[xxx]       | Total bytes was used to cache the index and filter block.                                                                                                    |
+| level0_file_limit_slowdown[xxx]         | xxx.                                                                                                    |
+| level0_file_limit_stop[xxx]             | xxx.                                                                                                    |
+| pending_compaction_bytes_slowdown[xxx]  | xxx.                                                                                                    |
+| pending_compaction_bytes_stop[xxx]      | xxx.                                                                                                    |
+| memtable_count_limit_slowdown[xxx]      | xxx.                                                                                                    |

Review Comment:
   ```suggestion
   | memtable_count_limit_slowdown[xxx]      | Number of IO write stalls caused by reaching the memtable count slowdown limit.                                                                                              |
   ```



##########
docs/info-sections.md:
##########
@@ -272,18 +340,25 @@ There are five column families on kvrocks:
 |---------------|------------------------------------------------------------------------------------------------------------|
 | default       | Used to store the subkeys of the complex data structure like hash/set/list/zset/geo.                       |
 | metadata      | Used to store the metadata of the complex data structure and string.                                       |
-| zset score    | Used to store the mapping of zset's score to member, which would make the range by score operation faster. |
+| zset_score    | Used to store the mapping of zset's score to member, which would make the range by score operation faster. |
 | pubsub        | Used to propagate the pubsub message to replicas.                                                          |
 | propagate     | Used to propagate other commands to replicas except pubsub message.                                        |
+| stream        | xxx.                                        |
 
 ... and below statistics were column family related:
 
-| Property                      | Desc                                                                                                                                                         |
-|-------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| estimate_keys[xxx]            | Estimate keys in the column family, may contains the tombstone and expired keys, it's a fast way to know how many keys on the column family but not precise. |
-| block_cache_usage[xxx]        | Total block cache bytes used by this column family.                                                                                                          |
-| block_cache_pinned_usage[xxx] | Total pinned bytes in this column family.                                                                                                                    |
-| index_and_filter_cache_usage  | Total bytes was used to cache the index and filter block.                                                                                                    |
+| Property                                | Desc                                                                                                                                                         |
+|-----------------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| estimate_keys[xxx]                      | Estimate keys in the column family, may contains the tombstone and expired keys, it's a fast way to know how many keys on the column family but not precise. |
+| block_cache_usage[xxx]                  | Total block cache bytes used by this column family.                                                                                                          |
+| block_cache_pinned_usage[xxx]           | Total pinned bytes in this column family.                                                                                                                    |
+| index_and_filter_cache_usage[xxx]       | Total bytes was used to cache the index and filter block.                                                                                                    |
+| level0_file_limit_slowdown[xxx]         | xxx.                                                                                                    |
+| level0_file_limit_stop[xxx]             | xxx.                                                                                                    |
+| pending_compaction_bytes_slowdown[xxx]  | xxx.                                                                                                    |

Review Comment:
   ```suggestion
   | pending_compaction_bytes_slowdown[xxx]  | Number of IO write stalls caused reaching the pending compaction bytes slowdown limit.                                                                                                    |
   ```



##########
docs/info-sections.md:
##########
@@ -298,8 +373,14 @@ There are five column families on kvrocks:
 | compaction_pending      | This metric returns 1 if at least one compaction is pending; otherwise, the metric reports 0.                                              |
 | num_running_compactions | Number of currently running compactions.                                                                                                   |
 | num_live_versions       | Number of live versions. More live versions often mean more SST files are held from being deleted, by iterators or unfinished compactions. |
+| num_super_version       | xxx. |

Review Comment:
   ```suggestion
   | num_super_version       | Number of the super version inside the RocksDB. |
   ```



##########
docs/info-sections.md:
##########
@@ -272,18 +340,25 @@ There are five column families on kvrocks:
 |---------------|------------------------------------------------------------------------------------------------------------|
 | default       | Used to store the subkeys of the complex data structure like hash/set/list/zset/geo.                       |
 | metadata      | Used to store the metadata of the complex data structure and string.                                       |
-| zset score    | Used to store the mapping of zset's score to member, which would make the range by score operation faster. |
+| zset_score    | Used to store the mapping of zset's score to member, which would make the range by score operation faster. |
 | pubsub        | Used to propagate the pubsub message to replicas.                                                          |
 | propagate     | Used to propagate other commands to replicas except pubsub message.                                        |
+| stream        | xxx.                                        |
 
 ... and below statistics were column family related:
 
-| Property                      | Desc                                                                                                                                                         |
-|-------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| estimate_keys[xxx]            | Estimate keys in the column family, may contains the tombstone and expired keys, it's a fast way to know how many keys on the column family but not precise. |
-| block_cache_usage[xxx]        | Total block cache bytes used by this column family.                                                                                                          |
-| block_cache_pinned_usage[xxx] | Total pinned bytes in this column family.                                                                                                                    |
-| index_and_filter_cache_usage  | Total bytes was used to cache the index and filter block.                                                                                                    |
+| Property                                | Desc                                                                                                                                                         |
+|-----------------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| estimate_keys[xxx]                      | Estimate keys in the column family, may contains the tombstone and expired keys, it's a fast way to know how many keys on the column family but not precise. |
+| block_cache_usage[xxx]                  | Total block cache bytes used by this column family.                                                                                                          |
+| block_cache_pinned_usage[xxx]           | Total pinned bytes in this column family.                                                                                                                    |
+| index_and_filter_cache_usage[xxx]       | Total bytes was used to cache the index and filter block.                                                                                                    |
+| level0_file_limit_slowdown[xxx]         | xxx.                                                                                                    |

Review Comment:
   ```suggestion
   | level0_file_limit_slowdown[xxx]         | Number of IO write stalls caused by reaching the level0 file slowdown limit.                                                                                                    |
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org