You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jens Geyer (JIRA)" <ji...@apache.org> on 2014/04/17 23:23:15 UTC

[jira] [Commented] (THRIFT-2473) _isset entries shouldn't be generated for non-optional fields

    [ https://issues.apache.org/jira/browse/THRIFT-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973426#comment-13973426 ] 

Jens Geyer commented on THRIFT-2473:
------------------------------------

Hi [~vlovich],

could you please indicate what language you are talking about? Simply set the component at the ticket, that avoids a lot of possible confusion. 

Thanks!

> _isset entries shouldn't be generated for non-optional fields
> -------------------------------------------------------------
>
>                 Key: THRIFT-2473
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2473
>             Project: Thrift
>          Issue Type: Bug
>            Reporter: Vitali Lovich
>
> There's quite a bit of memory overhead (4 bytes per field) that's wasted on every single type.  The __isset field is unused by the thrift type for fields not annotated optional.
> Additionally, it causes confusion in program code since people never know whether or not the __isset struct can be checked for a particular field or not (e.g. for non-optional fields it would never get set normally unless you deserialized it).



--
This message was sent by Atlassian JIRA
(v6.2#6252)