[jira] [Commented] (FLINK-10553) Unified sink and source table name in SQL statement

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650409#comment-16650409 ] 

ASF GitHub Bot commented on FLINK-10553:
----------------------------------------

jrthe42 opened a new pull request #6847: [FLINK-10553] [sql] Unified sink and source table name in SQL statement
URL: https://github.com/apache/flink/pull/6847
 
 
   ## What is the purpose of the change
   This pull request solves a bug in flink SQL statement, in which sink table name in INSERT INTO clause can only be enclosed in back-ticks. The sink table name should be consisted with source table name in FROM clause.
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as *ExternalCatalogInsertTest#testBatchSQL*, *ExternalCatalogInsertTest#testStreamSQL*.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Unified sink and source table name in SQL statement
> ---------------------------------------------------
>
>                 Key: FLINK-10553
>                 URL: https://issues.apache.org/jira/browse/FLINK-10553
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>    Affects Versions: 1.6.0, 1.7.0
>            Reporter: wangsan
>            Assignee: wangsan
>            Priority: Major
>              Labels: pull-request-available
>
> Since sink table can now be registered using ExternalCatalog, just the same as source table, the source and sink name in SQL statement should also be treated equally. Now we can only use `catalog.database.table` for sink table (enclosed in back-ticks as a identifier), this is not consistent with source table name (do not treat the whole name as a identifier). 
> *INSERT INTO catalog.database.sinktable SELECT ... FROM catalog.database.sourcetable* should be supported .



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)