You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/12/18 00:10:05 UTC
[kudu-CR] util: remove test-only metrics from header
Hello Alexey Serbin, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14919
to review the following change.
Change subject: util: remove test-only metrics from header
......................................................................
util: remove test-only metrics from header
It's easy for these metrics to accidentally be included in any
metrics-collection that is based off of the Kudu binaries, so I moved
them into the test file in which they're used.
Change-Id: Ie945c503c2821c873c1cff30eb0b04b3c2e03ba0
---
M src/kudu/util/CMakeLists.txt
M src/kudu/util/ttl_cache-test.cc
D src/kudu/util/ttl_cache_test_metrics.cc
D src/kudu/util/ttl_cache_test_metrics.h
4 files changed, 63 insertions(+), 125 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/14919/1
--
To view, visit http://gerrit.cloudera.org:8080/14919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie945c503c2821c873c1cff30eb0b04b3c2e03ba0
Gerrit-Change-Number: 14919
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] util: remove test-only metrics from header
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14919 )
Change subject: util: remove test-only metrics from header
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14919/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14919/1//COMMIT_MSG@9
PS1, Line 9: in any
: metrics-collection that is based off of the Kudu binaries
what are these?
--
To view, visit http://gerrit.cloudera.org:8080/14919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie945c503c2821c873c1cff30eb0b04b3c2e03ba0
Gerrit-Change-Number: 14919
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 18 Dec 2019 00:35:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] util: remove test-only metrics from header
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14919
to look at the new patch set (#2).
Change subject: util: remove test-only metrics from header
......................................................................
util: remove test-only metrics from header
It's easy for these metrics to accidentally be included in any
metrics-collection that is based off of the Kudu binaries, so I moved
them into the test file in which they're used.
Change-Id: Ie945c503c2821c873c1cff30eb0b04b3c2e03ba0
---
M src/kudu/util/CMakeLists.txt
M src/kudu/util/ttl_cache-test.cc
D src/kudu/util/ttl_cache_test_metrics.cc
D src/kudu/util/ttl_cache_test_metrics.h
4 files changed, 64 insertions(+), 126 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/14919/2
--
To view, visit http://gerrit.cloudera.org:8080/14919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie945c503c2821c873c1cff30eb0b04b3c2e03ba0
Gerrit-Change-Number: 14919
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] util: remove test-only metrics from header
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14919 )
Change subject: util: remove test-only metrics from header
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie945c503c2821c873c1cff30eb0b04b3c2e03ba0
Gerrit-Change-Number: 14919
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 18 Dec 2019 01:04:30 +0000
Gerrit-HasComments: No
[kudu-CR] util: remove test-only metrics from header
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14919 )
Change subject: util: remove test-only metrics from header
......................................................................
Patch Set 2: Code-Review+2
Thank you for fixing this issue!
--
To view, visit http://gerrit.cloudera.org:8080/14919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie945c503c2821c873c1cff30eb0b04b3c2e03ba0
Gerrit-Change-Number: 14919
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 18 Dec 2019 02:03:32 +0000
Gerrit-HasComments: No
[kudu-CR] util: remove test-only metrics from header
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14919 )
Change subject: util: remove test-only metrics from header
......................................................................
util: remove test-only metrics from header
It's easy for these metrics to accidentally be included in any
metrics-collection that is based off of the Kudu binaries, so I moved
them into the test file in which they're used.
Change-Id: Ie945c503c2821c873c1cff30eb0b04b3c2e03ba0
Reviewed-on: http://gerrit.cloudera.org:8080/14919
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/util/CMakeLists.txt
M src/kudu/util/ttl_cache-test.cc
D src/kudu/util/ttl_cache_test_metrics.cc
D src/kudu/util/ttl_cache_test_metrics.h
4 files changed, 64 insertions(+), 126 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie945c503c2821c873c1cff30eb0b04b3c2e03ba0
Gerrit-Change-Number: 14919
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] util: remove test-only metrics from header
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14919 )
Change subject: util: remove test-only metrics from header
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie945c503c2821c873c1cff30eb0b04b3c2e03ba0
Gerrit-Change-Number: 14919
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 18 Dec 2019 01:39:45 +0000
Gerrit-HasComments: No
[kudu-CR] util: remove test-only metrics from header
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14919 )
Change subject: util: remove test-only metrics from header
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14919/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14919/1//COMMIT_MSG@9
PS1, Line 9: in any
: metrics-collection that is based off of the Kudu binaries
> what are these?
Some systems will use `kudu-master --dump_metrics_json` and `kudu-tserver --dump_metrics_json` to generate the list of metrics to monitor.
--
To view, visit http://gerrit.cloudera.org:8080/14919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie945c503c2821c873c1cff30eb0b04b3c2e03ba0
Gerrit-Change-Number: 14919
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 18 Dec 2019 00:40:07 +0000
Gerrit-HasComments: Yes