You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bcel-dev@jakarta.apache.org by db...@apache.org on 2006/08/30 23:55:20 UTC
svn commit: r438659 -
/jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/InstructionFactory.java
Author: dbrosius
Date: Wed Aug 30 14:55:19 2006
New Revision: 438659
URL: http://svn.apache.org/viewvc?rev=438659&view=rev
Log:
constant arrays should be static final
Modified:
jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/InstructionFactory.java
Modified: jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/InstructionFactory.java
URL: http://svn.apache.org/viewvc/jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/InstructionFactory.java?rev=438659&r1=438658&r2=438659&view=diff
==============================================================================
--- jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/InstructionFactory.java (original)
+++ jakarta/bcel/trunk/src/main/java/org/apache/bcel/generic/InstructionFactory.java Wed Aug 30 14:55:19 2006
@@ -30,6 +30,10 @@
*/
public class InstructionFactory implements InstructionConstants, java.io.Serializable {
+ private static final String[] short_names = {
+ "C", "F", "D", "B", "S", "I", "L"
+ };
+
protected ClassGen cg;
protected ConstantPoolGen cp;
@@ -548,9 +552,6 @@
&& (src == Constants.T_CHAR || src == Constants.T_BYTE || src == Constants.T_SHORT)) {
src = Constants.T_INT;
}
- String[] short_names = {
- "C", "F", "D", "B", "S", "I", "L"
- };
String name = "org.apache.bcel.generic." + short_names[src - Constants.T_CHAR] + "2"
+ short_names[dest - Constants.T_CHAR];
Instruction i = null;
---------------------------------------------------------------------
To unsubscribe, e-mail: bcel-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: bcel-dev-help@jakarta.apache.org