You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Allen Wittenauer (Created) (JIRA)" <ji...@apache.org> on 2011/11/04 16:55:51 UTC
[jira] [Created] (HDFS-2538) option for fsck dots to be on/off
option for fsck dots to be on/off
----------------------------------
Key: HDFS-2538
URL: https://issues.apache.org/jira/browse/HDFS-2538
Project: Hadoop HDFS
Issue Type: New Feature
Reporter: Allen Wittenauer
this patch turns the dots during fsck off by default and provides an option to turn them back on if you have a fetish for millions and millions of dots on your terminal. i haven't done any benchmarks, but i suspect fsck is now 300% faster to boot.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2538) option to disable fsck dots
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-2538:
------------------------------
Summary: option to disable fsck dots (was: option for fsck dots to be on/off )
> option to disable fsck dots
> ----------------------------
>
> Key: HDFS-2538
> URL: https://issues.apache.org/jira/browse/HDFS-2538
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 0.20.204.0, 1.0.0
> Reporter: Allen Wittenauer
> Priority: Minor
> Labels: newbie
> Attachments: HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch
>
>
> this patch turns the dots during fsck off by default and provides an option to turn them back on if you have a fetish for millions and millions of dots on your terminal. i haven't done any benchmarks, but i suspect fsck is now 300% faster to boot.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2538) option for fsck dots to be on/off
Posted by "Allen Wittenauer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Allen Wittenauer updated HDFS-2538:
-----------------------------------
Attachment: HDFS-2538-branch-0.20-security-204.patch
> option for fsck dots to be on/off
> ----------------------------------
>
> Key: HDFS-2538
> URL: https://issues.apache.org/jira/browse/HDFS-2538
> Project: Hadoop HDFS
> Issue Type: New Feature
> Reporter: Allen Wittenauer
> Attachments: HDFS-2538-branch-0.20-security-204.patch
>
>
> this patch turns the dots during fsck off by default and provides an option to turn them back on if you have a fetish for millions and millions of dots on your terminal. i haven't done any benchmarks, but i suspect fsck is now 300% faster to boot.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2538) option for fsck dots to be on/off
Posted by "Allen Wittenauer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Allen Wittenauer updated HDFS-2538:
-----------------------------------
Affects Version/s: 0.20.204.0
1.0.0
> option for fsck dots to be on/off
> ----------------------------------
>
> Key: HDFS-2538
> URL: https://issues.apache.org/jira/browse/HDFS-2538
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 0.20.204.0, 1.0.0
> Reporter: Allen Wittenauer
> Priority: Minor
> Attachments: HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch
>
>
> this patch turns the dots during fsck off by default and provides an option to turn them back on if you have a fetish for millions and millions of dots on your terminal. i haven't done any benchmarks, but i suspect fsck is now 300% faster to boot.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2538) option for fsck dots to be on/off
Posted by "Todd Lipcon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144098#comment-13144098 ]
Todd Lipcon commented on HDFS-2538:
-----------------------------------
Given we know how many files/blocks/whatevers we have in the namespace before we even start the operation, maybe we can just make the dot frequency relative to that? eg print a dot for every 1% or 5% so you just get a line or two, but still have some indication of progress?
> option for fsck dots to be on/off
> ----------------------------------
>
> Key: HDFS-2538
> URL: https://issues.apache.org/jira/browse/HDFS-2538
> Project: Hadoop HDFS
> Issue Type: New Feature
> Reporter: Allen Wittenauer
> Attachments: HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-0.20-security-204.patch
>
>
> this patch turns the dots during fsck off by default and provides an option to turn them back on if you have a fetish for millions and millions of dots on your terminal. i haven't done any benchmarks, but i suspect fsck is now 300% faster to boot.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2538) option for fsck dots to be on/off
Posted by "Allen Wittenauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476730#comment-13476730 ]
Allen Wittenauer commented on HDFS-2538:
----------------------------------------
FWIW, I don't really plan on making a new version of this patch. I have had it checked into my tree for almost a year now. Given how easy it is to do merges now that Apache trees are available via git, I really have no inclination to spend the effort to get it committed. If someone else wants to spend the cycles, fine whatever.
> option for fsck dots to be on/off
> ----------------------------------
>
> Key: HDFS-2538
> URL: https://issues.apache.org/jira/browse/HDFS-2538
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 0.20.204.0, 1.0.0
> Reporter: Allen Wittenauer
> Priority: Minor
> Attachments: HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch
>
>
> this patch turns the dots during fsck off by default and provides an option to turn them back on if you have a fetish for millions and millions of dots on your terminal. i haven't done any benchmarks, but i suspect fsck is now 300% faster to boot.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2538) option for fsck dots to be on/off
Posted by "Allen Wittenauer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Allen Wittenauer updated HDFS-2538:
-----------------------------------
Attachment: HDFS-2538-branch-1.0.patch
Updated for 1.0 and fixes a slight output bug.
> option for fsck dots to be on/off
> ----------------------------------
>
> Key: HDFS-2538
> URL: https://issues.apache.org/jira/browse/HDFS-2538
> Project: Hadoop HDFS
> Issue Type: New Feature
> Reporter: Allen Wittenauer
> Attachments: HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch
>
>
> this patch turns the dots during fsck off by default and provides an option to turn them back on if you have a fetish for millions and millions of dots on your terminal. i haven't done any benchmarks, but i suspect fsck is now 300% faster to boot.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2538) option for fsck dots to be on/off
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475594#comment-13475594 ]
Steve Loughran commented on HDFS-2538:
--------------------------------------
think annoying should be the default for compatibility, then you could make the parameter -quiet
> option for fsck dots to be on/off
> ----------------------------------
>
> Key: HDFS-2538
> URL: https://issues.apache.org/jira/browse/HDFS-2538
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 0.20.204.0, 1.0.0
> Reporter: Allen Wittenauer
> Priority: Minor
> Attachments: HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch
>
>
> this patch turns the dots during fsck off by default and provides an option to turn them back on if you have a fetish for millions and millions of dots on your terminal. i haven't done any benchmarks, but i suspect fsck is now 300% faster to boot.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2538) option for fsck dots to be on/off
Posted by "Andy Isaacson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476460#comment-13476460 ]
Andy Isaacson commented on HDFS-2538:
-------------------------------------
The option needs to be "verbose"/"quiet" or "progress"/"noprogress" rather than "annoying". (Although I find it annoying too.)
I think, regrettably, that this counts as an incompatible change, if the default behavior is changed. I'd like to see progress turned off for trunk, with a -progress option to turn it back on; and progress on by default for stable branches, with a -noprogress option to turn it off.
The branch-1 patch is missing the DFSck.java change to add "-annoying".
> option for fsck dots to be on/off
> ----------------------------------
>
> Key: HDFS-2538
> URL: https://issues.apache.org/jira/browse/HDFS-2538
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 0.20.204.0, 1.0.0
> Reporter: Allen Wittenauer
> Priority: Minor
> Attachments: HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch
>
>
> this patch turns the dots during fsck off by default and provides an option to turn them back on if you have a fetish for millions and millions of dots on your terminal. i haven't done any benchmarks, but i suspect fsck is now 300% faster to boot.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2538) option for fsck dots to be on/off
Posted by "Kihwal Lee (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144102#comment-13144102 ]
Kihwal Lee commented on HDFS-2538:
----------------------------------
I like the patch very much, but at the same time the part I like the most may need some changes. :)
- Instead of {{-annoying}}, {{-verbose}} or {{-progress}} would be nice.
- At the same time, can we change {{%100}} to something bigger?
> option for fsck dots to be on/off
> ----------------------------------
>
> Key: HDFS-2538
> URL: https://issues.apache.org/jira/browse/HDFS-2538
> Project: Hadoop HDFS
> Issue Type: New Feature
> Reporter: Allen Wittenauer
> Attachments: HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-0.20-security-204.patch
>
>
> this patch turns the dots during fsck off by default and provides an option to turn them back on if you have a fetish for millions and millions of dots on your terminal. i haven't done any benchmarks, but i suspect fsck is now 300% faster to boot.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2538) option for fsck dots to be on/off
Posted by "Allen Wittenauer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Allen Wittenauer updated HDFS-2538:
-----------------------------------
Priority: Minor (was: Major)
Issue Type: Improvement (was: New Feature)
> option for fsck dots to be on/off
> ----------------------------------
>
> Key: HDFS-2538
> URL: https://issues.apache.org/jira/browse/HDFS-2538
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Allen Wittenauer
> Priority: Minor
> Attachments: HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-1.0.patch
>
>
> this patch turns the dots during fsck off by default and provides an option to turn them back on if you have a fetish for millions and millions of dots on your terminal. i haven't done any benchmarks, but i suspect fsck is now 300% faster to boot.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2538) option for fsck dots to be on/off
Posted by "Allen Wittenauer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Allen Wittenauer updated HDFS-2538:
-----------------------------------
Attachment: HDFS-2538-branch-0.20-security-204.patch
woops this included another patch. let's try that again.
> option for fsck dots to be on/off
> ----------------------------------
>
> Key: HDFS-2538
> URL: https://issues.apache.org/jira/browse/HDFS-2538
> Project: Hadoop HDFS
> Issue Type: New Feature
> Reporter: Allen Wittenauer
> Attachments: HDFS-2538-branch-0.20-security-204.patch, HDFS-2538-branch-0.20-security-204.patch
>
>
> this patch turns the dots during fsck off by default and provides an option to turn them back on if you have a fetish for millions and millions of dots on your terminal. i haven't done any benchmarks, but i suspect fsck is now 300% faster to boot.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira