You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2023/01/06 11:37:03 UTC
[GitHub] [rocketmq-dashboard] cndoit18 opened a new pull request, #134: fix(Dockerfile): Unable to build docker image
cndoit18 opened a new pull request, #134:
URL: https://github.com/apache/rocketmq-dashboard/pull/134
Signed-off-by: cndoit18 <cn...@outlook.com>
## What is the purpose of the change
Fix the problem of not being able to build docker image
Use multi-stage builds to optimize
## Brief changelog
Fix the problem of not being able to build docker image
Use multi-stage builds to optimize
## Verifying this change
`ghcr.io/cndoit18/rocketmq-dashboard:latest`
This image can be run to test
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(Dockerfile): Unable to build docker image [rocketmq-dashboard]
Posted by "cndoit18 (via GitHub)" <gi...@apache.org>.
cndoit18 closed pull request #134: fix(Dockerfile): Unable to build docker image
URL: https://github.com/apache/rocketmq-dashboard/pull/134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-dashboard] cndoit18 commented on pull request #134: fix(Dockerfile): Unable to build docker image
Posted by GitBox <gi...@apache.org>.
cndoit18 commented on PR #134:
URL: https://github.com/apache/rocketmq-dashboard/pull/134#issuecomment-1376877292
cc @zhangjidi2016
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org