You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Bhupendra Bhardwaj <bh...@gmail.com> on 2007/03/08 12:16:31 UTC

[Java] systests

Hi all,

I was running the tests in the systests module and saw 16 failures out of 45
tests. Some of those even throwing NullPointerException.
Those tests are not up to date with the changes in the trunk. And I think
the reason behind that is that those tests don't get run with mvn.

I am thinking of updating the pom to get those tests run with mvn. I wanted
to check with all if there was a reason why those were not setup to run with
mvn at first place. If those are supposed to be run seperately and not with
mvn then there is nothing to make sure that those are run.

Let me know your thoughts and we can take appropriate action.

Regards,
Bhupendra

Re: [Java] systests

Posted by Jonathan Anstey <ja...@iona.com>.
Wow, the systests have been disabled since January 11th! They were 
running with mvn before that. IMO we should enable these ASAP.

Cheers,
Jon

Bhupendra Bhardwaj wrote:
> Hi all,
>
> I was running the tests in the systests module and saw 16 failures out 
> of 45
> tests. Some of those even throwing NullPointerException.
> Those tests are not up to date with the changes in the trunk. And I think
> the reason behind that is that those tests don't get run with mvn.
>
> I am thinking of updating the pom to get those tests run with mvn. I 
> wanted
> to check with all if there was a reason why those were not setup to 
> run with
> mvn at first place. If those are supposed to be run seperately and not 
> with
> mvn then there is nothing to make sure that those are run.
>
> Let me know your thoughts and we can take appropriate action.
>
> Regards,
> Bhupendra
>


Re: [Java] systests

Posted by Bhupendra Bhardwaj <bh...@gmail.com>.
On 3/8/07, Alan Conway <ac...@redhat.com> wrote:
>
> My philosophy is to run all tests by default, but provide switches for
> developers to select subsets to focus on a particular area. If there are
> tests "on the side" that aren't run by default, typically they get
> forgotten.


Now we are using maven, so maven provides features to include/exclude tests
in pom.
And on command line , to exclude running the test we use -Pfastinstall.
To run only tests we can use "mvn test" and to run only one test we can use
"mvn -Dtest=<testname>"


The only exception I would make is stress or performance tests that
> need to run for many minutes or even hours. To avoid forgetting they
> should be run regularly by an automated build - which is coming soon I
> believe :)
>
> Cheers,
> Alan.



Right. Stress and performance tests shouldn't be part of default mvn run.
Automated build will be run at specific time everyday or at whatever
interval we configure it. But for developers, who are committing code to the
trunk, they should be able to run mvn and see if something is broken.That is
what I was doing and didn't realise that certain tests don't get executed
only.

I will be fixing those tests, which aren't working and if all feel it is
good idea to put those as part of mvn run, then will do that too.

Regards,
Bhupendra B

Re: [Java] systests

Posted by Alan Conway <ac...@redhat.com>.
Bhupendra Bhardwaj wrote:
> Hi all,
>
> I was running the tests in the systests module and saw 16 failures out 
> of 45
> tests. Some of those even throwing NullPointerException.
> Those tests are not up to date with the changes in the trunk. And I think
> the reason behind that is that those tests don't get run with mvn.
>
> I am thinking of updating the pom to get those tests run with mvn. I 
> wanted
> to check with all if there was a reason why those were not setup to 
> run with
> mvn at first place. If those are supposed to be run seperately and not 
> with
> mvn then there is nothing to make sure that those are run.
My philosophy is to run all tests by default, but provide switches for 
developers to select subsets to focus on a particular area. If there are 
tests "on the side" that aren't run by default, typically they get 
forgotten.

 The only exception I would make is stress or performance tests that 
need to run for many minutes or even hours. To avoid forgetting they 
should be run regularly by an automated build - which is coming soon I 
believe :)

Cheers,
Alan.