You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/04 07:25:48 UTC

[GitHub] [kafka] dongjinleekr opened a new pull request #10260: KAFKA-12409: Leaking gauge in ReplicaManager

dongjinleekr opened a new pull request #10260:
URL: https://github.com/apache/kafka/pull/10260


   One gauge is missing in `ReplicaManager#removeMetrics`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] dongjinleekr commented on pull request #10260: KAFKA-12409: Leaking gauge in ReplicaManager

Posted by GitBox <gi...@apache.org>.
dongjinleekr commented on pull request #10260:
URL: https://github.com/apache/kafka/pull/10260#issuecomment-790387465


   @ableegoldman Could you have a look? Maybe it should be cherry-picked into 2.6.2.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ableegoldman commented on pull request #10260: KAFKA-12409: Leaking gauge in ReplicaManager

Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10260:
URL: https://github.com/apache/kafka/pull/10260#issuecomment-790990198


   Cherrypicked to 2.7 and 2.6


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] dongjinleekr commented on pull request #10260: KAFKA-12409: Leaking gauge in ReplicaManager

Posted by GitBox <gi...@apache.org>.
dongjinleekr commented on pull request #10260:
URL: https://github.com/apache/kafka/pull/10260#issuecomment-790408277


   @chia7712 Thanks. Please have a look to the related issues, [KAFKA-12407](https://issues.apache.org/jira/browse/KAFKA-12407) and [KAFKA-12408](https://issues.apache.org/jira/browse/KAFKA-12408).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ableegoldman merged pull request #10260: KAFKA-12409: Leaking gauge in ReplicaManager

Posted by GitBox <gi...@apache.org>.
ableegoldman merged pull request #10260:
URL: https://github.com/apache/kafka/pull/10260


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ableegoldman commented on pull request #10260: KAFKA-12409: Leaking gauge in ReplicaManager

Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10260:
URL: https://github.com/apache/kafka/pull/10260#issuecomment-790988978


   Merged to trunk. Will also cherrypick to 2.7 and 2.6 since I'm still in the process of cutting the 2.6.2 RC -- you should check with @vvcephei where we are in the 2.8 release cycle and whether we should cherrypick this to 2.8 (it seems to be not a blocker, but also low-risk, is that fair?)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org