[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2408: SOLR-13034: RTG sometimes didn't materialize LazyField

[GitBox <gi...@apache.org>]

dsmiley commented on a change in pull request #2408:
URL: https://github.com/apache/lucene-solr/pull/2408#discussion_r581407353



##########
File path: solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java
##########
@@ -813,8 +813,8 @@ private static SolrInputDocument toSolrInputDocument(SolrDocument doc, IndexSche
         if ((!sf.hasDocValues() && !sf.stored()) || schema.isCopyFieldTarget(sf)) continue;
       }
       for (Object val: doc.getFieldValues(fname)) {
-        if (val instanceof Field) {
-          Field f = (Field) val;
+        if (val instanceof IndexableField) {
+          IndexableField f = materialize((IndexableField) val);

Review comment:
       Spot on!
   I'm now looking to see if I can do some simplifications here; tay tuned...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org