You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/01/07 04:56:19 UTC
[GitHub] [incubator-doris] yangzhg opened a new pull request #2682: Fix
incompatibility with arm architecture in olap #2645
yangzhg opened a new pull request #2682: Fix incompatibility with arm architecture in olap #2645
URL: https://github.com/apache/incubator-doris/pull/2682
1. Add macros in olap code to be compatible with arm instruction set
2. Replace atomic functions in olap whit gutils/atomicops
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request
#2682: Fix incompatibility with arm architecture in olap #2645
Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #2682: Fix incompatibility with arm architecture in olap #2645
URL: https://github.com/apache/incubator-doris/pull/2682#discussion_r363605687
##########
File path: be/src/olap/storage_engine.h
##########
@@ -310,6 +308,8 @@ class StorageEngine {
uint32_t _min_percentage_of_error_disk;
Cache* _file_descriptor_lru_cache;
Cache* _index_stream_lru_cache;
+ uint32_t _max_base_compaction_task_per_disk;
+ uint32_t _max_cumulative_compaction_task_per_disk;
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request
#2682: Fix incompatibility with arm architecture in olap #2645
Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #2682: Fix incompatibility with arm architecture in olap #2645
URL: https://github.com/apache/incubator-doris/pull/2682#discussion_r363605657
##########
File path: be/src/olap/rowset/segment_group.h
##########
@@ -291,7 +291,7 @@ class SegmentGroup {
PUniqueId _load_id; // load id for segmentgroup
int32_t _num_segments; // number of segments in this segmentgroup
bool _index_loaded; // whether the segmentgroup has been read
- atomic_t _ref_count; // reference count
+ base::subtle::Atomic64 _ref_count; // reference count
Review comment:
gutil/atomicops need this type
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #2682:
Fix incompatibility with arm architecture in olap #2645
Posted by GitBox <gi...@apache.org>.
imay commented on a change in pull request #2682: Fix incompatibility with arm architecture in olap #2645
URL: https://github.com/apache/incubator-doris/pull/2682#discussion_r363598540
##########
File path: be/src/olap/storage_engine.h
##########
@@ -310,6 +308,8 @@ class StorageEngine {
uint32_t _min_percentage_of_error_disk;
Cache* _file_descriptor_lru_cache;
Cache* _index_stream_lru_cache;
+ uint32_t _max_base_compaction_task_per_disk;
+ uint32_t _max_cumulative_compaction_task_per_disk;
Review comment:
uesless?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay merged pull request #2682: Fix
incompatibility with arm architecture in olap #2645
Posted by GitBox <gi...@apache.org>.
imay merged pull request #2682: Fix incompatibility with arm architecture in olap #2645
URL: https://github.com/apache/incubator-doris/pull/2682
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #2682:
Fix incompatibility with arm architecture in olap #2645
Posted by GitBox <gi...@apache.org>.
imay commented on a change in pull request #2682: Fix incompatibility with arm architecture in olap #2645
URL: https://github.com/apache/incubator-doris/pull/2682#discussion_r363599110
##########
File path: be/src/olap/bhp_lib.h
##########
@@ -789,6 +790,11 @@ inline int check_sse4_2() {
);
return ret;
}
+#else
+inline int check_sse4_2() {
Review comment:
Is this can be unified through CpuInfo?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #2682:
Fix incompatibility with arm architecture in olap #2645
Posted by GitBox <gi...@apache.org>.
imay commented on a change in pull request #2682: Fix incompatibility with arm architecture in olap #2645
URL: https://github.com/apache/incubator-doris/pull/2682#discussion_r363598855
##########
File path: be/src/olap/rowset/segment_group.h
##########
@@ -291,7 +291,7 @@ class SegmentGroup {
PUniqueId _load_id; // load id for segmentgroup
int32_t _num_segments; // number of segments in this segmentgroup
bool _index_loaded; // whether the segmentgroup has been read
- atomic_t _ref_count; // reference count
+ base::subtle::Atomic64 _ref_count; // reference count
Review comment:
prefer std::atomic<int32_t>.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org