You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by 10110346 <gi...@git.apache.org> on 2018/02/12 01:48:54 UTC
[GitHub] spark pull request #20581: [SPARK-23358][CORE][FOLLOW-UP]When reduceId is gr...
GitHub user 10110346 opened a pull request:
https://github.com/apache/spark/pull/20581
[SPARK-23358][CORE][FOLLOW-UP]When reduceId is greater than 2^28, reduceId*8 will overflow
## What changes were proposed in this pull request?
In the `getBlockData`,`blockId.reduceId` is the `Int` type, when it is greater than 2^28, `blockId.reduceId*8` will overflow
## How was this patch tested?
N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/10110346/spark overflow2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20581.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20581
----
commit 0d3884ad0d2fecf7595fc0c90338b014a3296e6a
Author: liuxian <li...@...>
Date: 2018-02-11T05:55:52Z
fix
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20581: [SPARK-23391][CORE]It may lead to overflow for some inte...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20581
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87315/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20581: [SPARK-23358][CORE][FOLLOW-UP]When reduceId is greater t...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20581
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/800/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20581: [SPARK-23391][CORE]It may lead to overflow for some inte...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20581
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20581: [SPARK-23391][CORE]It may lead to overflow for some inte...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20581
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87316/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20581: [SPARK-23358][CORE][FOLLOW-UP]When reduceId is greater t...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20581
**[Test build #87316 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87316/testReport)** for PR 20581 at commit [`d590768`](https://github.com/apache/spark/commit/d590768b19fd1e78073d83fd0954cde9e17ecfd9).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20581: [SPARK-23358][CORE][FOLLOW-UP]When reduceId is greater t...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20581
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20581: [SPARK-23358][CORE][FOLLOW-UP]When reduceId is greater t...
Posted by 10110346 <gi...@git.apache.org>.
Github user 10110346 commented on the issue:
https://github.com/apache/spark/pull/20581
@srowen I will check all of our code.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20581: [SPARK-23391][CORE]It may lead to overflow for some inte...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20581
Merged to master/2.3/2.2
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20581: [SPARK-23391][CORE]It may lead to overflow for some inte...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20581
**[Test build #87315 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87315/testReport)** for PR 20581 at commit [`0d3884a`](https://github.com/apache/spark/commit/0d3884ad0d2fecf7595fc0c90338b014a3296e6a).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20581: [SPARK-23391][CORE]It may lead to overflow for some inte...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20581
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20581: [SPARK-23358][CORE][FOLLOW-UP]When reduceId is greater t...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20581
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/799/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20581: [SPARK-23358][CORE][FOLLOW-UP]When reduceId is greater t...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20581
**[Test build #87315 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87315/testReport)** for PR 20581 at commit [`0d3884a`](https://github.com/apache/spark/commit/0d3884ad0d2fecf7595fc0c90338b014a3296e6a).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20581: [SPARK-23358][CORE][FOLLOW-UP]When reduceId is greater t...
Posted by 10110346 <gi...@git.apache.org>.
Github user 10110346 commented on the issue:
https://github.com/apache/spark/pull/20581
@srowen I am sorry, i didn't notice this place, i found it yesterday.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20581: [SPARK-23358][CORE][FOLLOW-UP]When reduceId is greater t...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20581
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20581: [SPARK-23391][CORE]It may lead to overflow for so...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20581
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20581: [SPARK-23391][CORE]It may lead to overflow for some inte...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20581
**[Test build #87316 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87316/testReport)** for PR 20581 at commit [`d590768`](https://github.com/apache/spark/commit/d590768b19fd1e78073d83fd0954cde9e17ecfd9).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20581: [SPARK-23358][CORE][FOLLOW-UP]When reduceId is greater t...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20581
Hm, why was this not part of the previous PR?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org