You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/12/20 02:00:17 UTC

[GitHub] [inlong] leezng commented on a diff in pull request #6927: [INLONG-6926][Dashboard] Cluster management type label, lower case

leezng commented on code in PR #6927:
URL: https://github.com/apache/inlong/pull/6927#discussion_r1052799061


##########
inlong-dashboard/src/metas/clusters/common/ClusterDefaultInfo.ts:
##########
@@ -58,7 +59,9 @@ export class ClusterDefaultInfo implements DataWithBackend, RenderRow, RenderLis
         })),
     },
   })
-  @ColumnDecorator()
+  @ColumnDecorator({
+    render: text => text && getClustersType(text),

Review Comment:
   It is recommended to use `clusters.find()` directly here, do not export a new method, to avoid the complexity of nesting design model relationships.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org