You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@eagle.apache.org by DadanielZ <gi...@git.apache.org> on 2017/02/07 05:57:17 UTC
[GitHub] eagle pull request #795: [EAGLE-881] Url of scala-tools repository is no lon...
GitHub user DadanielZ opened a pull request:
https://github.com/apache/eagle/pull/795
[EAGLE-881] Url of scala-tools repository is no longer valid
Removed the repositories declaration of "Scala-Tools Maven2 Repository" from "eagle-parent" pom file, so that maven can download them from default maven repo.
<!--
{% comment %}
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to you under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
{% endcomment %}
-->
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[EAGLE-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DadanielZ/eagle EAGLE-881
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/eagle/pull/795.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #795
----
commit 669940ec6a63e5a7ecef2ff73d9a6f13256034c8
Author: DadanielZ <da...@apache.org>
Date: 2017-02-07T05:55:26Z
EAGLE-881 Url of scala-tools repository is no longer valid
Removed the repositories declaration of "Scala-Tools Maven2 Repository" from "eagle-parent" pom file, so that maven can download them from default maven repo.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #795: [EAGLE-881] Url of scala-tools repository is no longer val...
Posted by DadanielZ <gi...@git.apache.org>.
Github user DadanielZ commented on the issue:
https://github.com/apache/eagle/pull/795
@haoch this is for branch-0.4, which should be using jdk 1.7 to build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #795: [EAGLE-881] Url of scala-tools repository is no longer val...
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/795
OK, please move on to merge the PR directly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #795: [EAGLE-881] Url of scala-tools repository is no longer val...
Posted by DadanielZ <gi...@git.apache.org>.
Github user DadanielZ commented on the issue:
https://github.com/apache/eagle/pull/795
merged, hence closing the PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #795: [EAGLE-881] Url of scala-tools repository is no longer val...
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/795
@DadanielZ is this PR still valid?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #795: [EAGLE-881] Url of scala-tools repository is no lon...
Posted by DadanielZ <gi...@git.apache.org>.
Github user DadanielZ closed the pull request at:
https://github.com/apache/eagle/pull/795
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #795: [EAGLE-881] Url of scala-tools repository is no longer val...
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/795
@DadanielZ eagle currently requires `jdk-1.8` to compile, why the build failed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #795: [EAGLE-881] Url of scala-tools repository is no longer val...
Posted by DadanielZ <gi...@git.apache.org>.
Github user DadanielZ commented on the issue:
https://github.com/apache/eagle/pull/795
Build failed because Jenkins is using jdk1.8 but not jdk1.7:
[ERROR] error: error while loading CharSequence, class file '/usr/local/asfpackages/java/jdk1.8.0_102/jre/lib/rt.jar(java/lang/CharSequence.class)' is broken
[INFO] (class java.lang.RuntimeException/bad constant pool tag 18 at byte 10)
[ERROR] error: error while loading AnnotatedElement, class file '/usr/local/asfpackages/java/jdk1.8.0_102/jre/lib/rt.jar(java/lang/reflect/AnnotatedElement.class)' is broken
[INFO] (class java.lang.RuntimeException/bad constant pool tag 18 at byte 76)
[ERROR] error: error while loading ConcurrentMap, class file '/usr/local/asfpackages/java/jdk1.8.0_102/jre/lib/rt.jar(java/util/concurrent/ConcurrentMap.class)' is broken
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #795: [EAGLE-881] Url of scala-tools repository is no longer val...
Posted by DadanielZ <gi...@git.apache.org>.
Github user DadanielZ commented on the issue:
https://github.com/apache/eagle/pull/795
@haoch Yes it is still valid. jenkin server is using jdk1.8 but not jdk1.7 to build ``branch-0.4``, which lead to the failure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---