You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "renovate-bot (via GitHub)" <gi...@apache.org> on 2026/06/09 01:50:36 UTC
[PR] Update dependency jakarta.servlet:jakarta.servlet-api to v6 [polaris]
renovate-bot opened a new pull request, #4666:
URL: https://github.com/apache/polaris/pull/4666
This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [jakarta.servlet:jakarta.servlet-api](https://projects.eclipse.org/projects/ee4j.servlet) ([source](https://redirect.github.com/eclipse-ee4j/servlet-api)) | `5.0.0` → `6.1.0` |  |  |
---
### Release Notes
<details>
<summary>eclipse-ee4j/servlet-api (jakarta.servlet:jakarta.servlet-api)</summary>
### [`v6.1.0`](https://redirect.github.com/eclipse-ee4j/servlet-api/compare/6.0.0-RELEASE...6.1.0-RELEASE)
[Compare Source](https://redirect.github.com/eclipse-ee4j/servlet-api/compare/6.0.0-RELEASE...6.1.0-RELEASE)
### [`v6.0.0`](https://redirect.github.com/eclipse-ee4j/servlet-api/compare/5.0.0-RELEASE...6.0.0-RELEASE)
[Compare Source](https://redirect.github.com/eclipse-ee4j/servlet-api/compare/5.0.0-RELEASE...6.0.0-RELEASE)
</details>
---
### Configuration
📅 **Schedule**: (UTC)
- Branch creation
- At any time (no schedule defined)
- Automerge
- At any time (no schedule defined)
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/apache/polaris).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yMDkuNCIsInVwZGF0ZWRJblZlciI6IjQzLjIwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS1wb2xhcmlzIl19-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update dependency jakarta.servlet:jakarta.servlet-api to v6 [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #4666:
URL: https://github.com/apache/polaris/pull/4666#discussion_r3429948889
##########
plugins/spark/v4.0/integration/build.gradle.kts:
##########
@@ -146,7 +146,7 @@ dependencies {
// Spark 4.0 requires version 5.0.0 which includes SingleThreadModel
// Quarkus BOM forces it to 6.x which removed SingleThreadModel
configurations.named("intTestRuntimeClasspath") {
- resolutionStrategy { force("jakarta.servlet:jakarta.servlet-api:5.0.0") }
+ resolutionStrategy { force("jakarta.servlet:jakarta.servlet-api:6.1.0") }
Review Comment:
I think we should ignore this dep update for now as it could be problematic with some "components" (spark, ...).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update dependency jakarta.servlet:jakarta.servlet-api to v6 [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #4666:
URL: https://github.com/apache/polaris/pull/4666#discussion_r3385996960
##########
plugins/spark/v4.0/integration/build.gradle.kts:
##########
@@ -146,7 +146,7 @@ dependencies {
// Spark 4.0 requires version 5.0.0 which includes SingleThreadModel
// Quarkus BOM forces it to 6.x which removed SingleThreadModel
configurations.named("intTestRuntimeClasspath") {
- resolutionStrategy { force("jakarta.servlet:jakarta.servlet-api:5.0.0") }
+ resolutionStrategy { force("jakarta.servlet:jakarta.servlet-api:6.1.0") }
Review Comment:
This force pins servlet-api *down* to 5.0.0 on purpose (see comment just above: 6.x removed SingleThreadModel that Spark 4.0 needs). Forcing 6.1.0 reintroduces exactly what the override was added to avoid and will likely break intTest. I think we may change the renovate rule for this to avoid new PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update dependency jakarta.servlet:jakarta.servlet-api to v6 [polaris]
Posted by "orca-review-bot (via GitHub) via issues" <is...@polaris.apache.org>.
orca-review-bot commented on code in PR #4666:
URL: https://github.com/apache/polaris/pull/4666#discussion_r4460639738
##########
plugins/spark/v4.0/spark/build.gradle.kts:
##########
@@ -210,7 +210,7 @@ listOf("intTestCompileClasspath", "intTestRuntimeClasspath").forEach {
// Spark 4.0 requires version 5.0.0 which includes SingleThreadModel
// Quarkus BOM forces it to 6.x which removed SingleThreadModel
configurations.named("intTestRuntimeClasspath") {
- resolutionStrategy { force("jakarta.servlet:jakarta.servlet-api:5.0.0") }
+ resolutionStrategy { force("jakarta.servlet:jakarta.servlet-api:6.1.0") }
Review Comment:
This force is meant to hold Servlet at 5.0.0. The comment right above says Spark 4.0 still needs `SingleThreadModel`, which Servlet 6 removed. The catalog and the Quarkus BOM already give 6.1.0, so forcing 6.1.0 means the override no longer does anything. Can we keep 5.0.0 here and close this PR?
<sub>🤖 AI-generated review comment — agents make mistakes, so please verify before acting on it.</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org