You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@groovy.apache.org by Balachandran Sivakumar <ba...@balachandran.org> on 2015/10/06 20:06:03 UTC
Build failing due to rat
Hi all,
When I run gradle build under the subprojects/performance folder, it is failing at the "rat" task saying unapproved/unknown licenses. It throws the error for the build.gradle file. If I add the standard apache license header to the file the error goes off. Is this something intentional for test purposes or should I send a PR with the license added ? Thanks
Re: Build failing due to rat
Posted by Cédric Champeau <ce...@gmail.com>.
@Paul: true, but we were really talking about the "performance" module that
I added recently, and which contains tests that compare various Groovy
runtimes.
2015-10-08 4:51 GMT+02:00 Paul King <pa...@asert.com.au>:
> Just as an additional point of clarification, the benchmark folder,
> while in our repo and something we have there to catch performance
> regressions, isn't part of our official Apache source distributions
> yet. Otherwise we would have caught this earlier. One of the issues is
> that it contains a bunch of micro-benchmark contributions which have
> been collected from numerous sources with unclear licensing in some
> cases. The other is that running this suite of benchmarks on anything
> but a dedicated and lightly-loaded machine will give spurious results
> over time (i.e. not suitable for most CI servers).
>
> On Thu, Oct 8, 2015 at 5:33 AM, Cédric Champeau
> <ce...@gmail.com> wrote:
> > Good catch. It wasn't intentional, I fixed it.
> >
> > 2015-10-06 20:06 GMT+02:00 Balachandran Sivakumar
> > <ba...@balachandran.org>:
> >>
> >> Hi all,
> >>
> >> When I run gradle build under the subprojects/performance
> folder,
> >> it is failing at the "rat" task saying unapproved/unknown licenses. It
> >> throws the error for the build.gradle file. If I add the standard apache
> >> license header to the file the error goes off. Is this something
> intentional
> >> for test purposes or should I send a PR with the license added ? Thanks
> >
> >
>
Re: Build failing due to rat
Posted by Paul King <pa...@asert.com.au>.
Just as an additional point of clarification, the benchmark folder,
while in our repo and something we have there to catch performance
regressions, isn't part of our official Apache source distributions
yet. Otherwise we would have caught this earlier. One of the issues is
that it contains a bunch of micro-benchmark contributions which have
been collected from numerous sources with unclear licensing in some
cases. The other is that running this suite of benchmarks on anything
but a dedicated and lightly-loaded machine will give spurious results
over time (i.e. not suitable for most CI servers).
On Thu, Oct 8, 2015 at 5:33 AM, Cédric Champeau
<ce...@gmail.com> wrote:
> Good catch. It wasn't intentional, I fixed it.
>
> 2015-10-06 20:06 GMT+02:00 Balachandran Sivakumar
> <ba...@balachandran.org>:
>>
>> Hi all,
>>
>> When I run gradle build under the subprojects/performance folder,
>> it is failing at the "rat" task saying unapproved/unknown licenses. It
>> throws the error for the build.gradle file. If I add the standard apache
>> license header to the file the error goes off. Is this something intentional
>> for test purposes or should I send a PR with the license added ? Thanks
>
>
Re: Build failing due to rat
Posted by Cédric Champeau <ce...@gmail.com>.
Good catch. It wasn't intentional, I fixed it.
2015-10-06 20:06 GMT+02:00 Balachandran Sivakumar <
balachandran@balachandran.org>:
> Hi all,
>
> When I run gradle build under the subprojects/performance folder,
> it is failing at the "rat" task saying unapproved/unknown licenses. It
> throws the error for the build.gradle file. If I add the standard apache
> license header to the file the error goes off. Is this something
> intentional for test purposes or should I send a PR with the license added
> ? Thanks
>