You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Qiang Zhang <zh...@zte.com.cn> on 2017/04/17 05:49:03 UTC
Review Request 58474: RANGER-1518:Do some code improvement for the
error message in PolicyMgrUserGroupBuilder.java
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58474/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1518
https://issues.apache.org/jira/browse/RANGER-1518
Repository: ranger
Description
-------
if (addUserGroupInfo(ugInfo) == null) {
String msg = "Failed to add add user group info";
LOG.error(msg);
throw new Exception(msg);
}
Duplicate 'add' for this error message.
Diffs
-----
ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java 070a39b
Diff: https://reviews.apache.org/r/58474/diff/1/
Testing
-------
Thanks,
Qiang Zhang
Re: Review Request 58474: RANGER-1518:Do some code improvement for
the error message in PolicyMgrUserGroupBuilder.java
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58474/#review172179
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On April 17, 2017, 5:49 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58474/
> -----------------------------------------------------------
>
> (Updated April 17, 2017, 5:49 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1518
> https://issues.apache.org/jira/browse/RANGER-1518
>
>
> Repository: ranger
>
>
> Description
> -------
>
> if (addUserGroupInfo(ugInfo) == null) {
> String msg = "Failed to add add user group info";
> LOG.error(msg);
> throw new Exception(msg);
> }
> Duplicate 'add' for this error message.
>
>
> Diffs
> -----
>
> ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java 070a39b
>
>
> Diff: https://reviews.apache.org/r/58474/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qiang Zhang
>
>