You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/30 22:37:23 UTC

[GitHub] [arrow] wjones127 commented on a diff in pull request #13486: ARROW-16936: [C++] Update gRPC absl static dependencies

wjones127 commented on code in PR #13486:
URL: https://github.com/apache/arrow/pull/13486#discussion_r911491851


##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -3834,7 +3834,55 @@ macro(build_grpc)
 
   list(APPEND
        ARROW_BUNDLED_STATIC_LIBS
-       ${GRPC_GPR_ABSL_LIBRARIES}
+       # This list of absl dependencies can be generated with:
+       # pkg-config --libs --static grpc \
+       #   | tr " " "\n" \
+       #   | grep ^-labsl_ \
+       #   | sed 's/^-labsl_/absl::/'

Review Comment:
   It should be able to be run anywhere as long as gRPC is on your `PKG_CONFIG_PATH`. If you have installed grpc via package manager then it will be. Otherwise you might have to add a build directory to that path. If you try to run the command and `grpc` isn't on the path, `pkg-config` will provide an error message saying it's not found and you should check your `PKG_CONFIG_PATH`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org