[GitHub] [maven] gnodet commented on pull request #819: Restore compatibility on SettingsBuilder, ToolchainsBuilder and MojoDescriptorCreator

[GitBox <gi...@apache.org>]

gnodet commented on PR #819:
URL: https://github.com/apache/maven/pull/819#issuecomment-1272627167

   > Can you elaborate on the change? When was it broken?
   
   When the v4 api was merged.  A few services were migrated to the new API, but that was a mistake because they are in use by plugins.  This is the case for the `ToolchainsBuilder` and the `MojoDescriptorCreator` as reported on https://lists.apache.org/list.html?dev@maven.apache.org. Whether those are considered internal or part of the real api could be discussed, but they were broken, as now is not the time to break compatibility.
   This PR then restores those services and add 2 new services to the new API to build settings and toolchains.
   
   I need to investigate why the IT is failing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org