You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by PaulAngus <gi...@git.apache.org> on 2016/09/23 19:41:29 UTC
[GitHub] cloudstack pull request #1688: Marvin Tests: Fix VPC network offering select...
GitHub user PaulAngus opened a pull request:
https://github.com/apache/cloudstack/pull/1688
Marvin Tests: Fix VPC network offering selection
It appears that original code did not expect there to be an alternate default VPC offering (Nuage) .
VPC selection uses isdefault=True which selects the Nuage Network offering, stopping the test from being run.
Fix was to look for name="Default VPC Offering" instead.
Replaces PR #1652 (same content, differenet branch)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack 4.8-marvintest-vpcofferingfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1688.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1688
----
commit 3bafd509caa5368bd7adbd81c65682dda5685b2f
Author: Paul Angus <pa...@shapeblue.com>
Date: 2016-09-23T19:40:36Z
Marvin Tests: Fix VPC network offering selection
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1688: Marvin Tests: Fix VPC network offering select...
Posted by PaulAngus <gi...@git.apache.org>.
Github user PaulAngus closed the pull request at:
https://github.com/apache/cloudstack/pull/1688
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1688: Marvin Tests: Fix VPC network offering selection
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1688
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1688: Marvin Tests: Fix VPC network offering selection
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1688
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1688: Marvin Tests: Fix VPC network offering selection
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1688
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1688: Marvin Tests: Fix VPC network offering selection
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1688
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1688: Marvin Tests: Fix VPC network offering selection
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1688
LGTM. Jenkins failure is not caused by change from the PR.
@abhinandanprateek @murali-reddy a second review please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1688: Marvin Tests: Fix VPC network offering selection
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1688
@PaulAngus can you please investigate/address the Jenkins build failure?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1688: Marvin Tests: Fix VPC network offering selection
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1688
<b>Trillian test result (tid-81)</b>
Environment: kvm-centos7 (x2), Advanced Networking
Total time taken: 25885 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1688-t81-kvm-centos7.zip
Test completed. 38 look ok, 11 have errors
Test | Result | Time (s)
--- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 153.194
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 82.841
test_02_vpc_privategw_static_routes | `Failure` | 77.786
test_01_vpc_privategw_acl | `Failure` | 52.342
test_router_dhcphosts | `Error` | 815.985
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | `Error` | 744.919
test_network_rules_acquired_public_ip_2_nat_rule | `Error` | 733.193
test_network_rules_acquired_public_ip_1_static_nat_rule | `Error` | 732.040
test_isolate_network_password_server | `Error` | 785.833
test_extendPhysicalNetworkVlan | `Error` | 0.034
test_dedicatePublicIpRange | `Error` | 0.308
test_07_quota | `Error` | 0.044
test_06_quota | `Error` | 0.038
test_05_quota | `Error` | 0.037
test_04_quota | `Error` | 0.037
test_03_quota | `Error` | 0.039
test_02_routervm_iptables_policies | `Error` | 775.581
test_02_quota | `Error` | 0.045
test_01_vpc_remote_access_vpn | `Error` | 0.099
test_01_snapshot_root_disk | `Error` | 0.100
test_01_single_VPC_iptables_policies | `Error` | 849.910
test_01_quota | `Error` | 0.049
ContextSuite context=TestRouterDHCPHosts>:teardown | `Error` | 867.395
ContextSuite context=TestDedicateGuestVlanRange>:setup | `Error` | 0.000
test_releaseIP | Success | 249.712
test_reboot_router | Success | 386.400
test_public_ip_user_account | Success | 10.258
test_public_ip_admin_account | Success | 40.462
test_nic_secondaryip_add_remove | Success | 193.732
test_network_acl | Success | 61.630
test_deployvm_userdispersing | Success | 20.736
test_deployvm_userdata_post | Success | 10.424
test_deployvm_userdata | Success | 51.015
test_deployvm_userconcentrated | Success | 21.027
test_deployvm_firstfit | Success | 51.033
test_deploy_vm_multiple | Success | 224.359
test_deploy_vm_from_iso | Success | 489.608
test_deploy_vm | Success | 0.030
test_delete_account | Success | 259.265
test_create_pvlan_network | Success | 5.402
test_createRegion | Success | 0.078
test_createPortablePublicIPRange | Success | 15.516
test_createPortablePublicIPAcquire | Success | 15.837
test_assign_and_removal_lb | Success | 133.785
test_advZoneVirtualRouter | Success | 0.022
test_UpdateStorageOverProvisioningFactor | Success | 0.137
test_UpdateConfigParamWithScope | Success | 0.328
test_DeployVmAntiAffinityGroup_in_project | Success | 97.030
test_DeployVmAntiAffinityGroup | Success | 66.386
test_CreateTemplateWithDuplicateName | Success | 70.748
test_10_destroy_cpvm | Success | 166.736
test_10_attachAndDetach_iso | Success | 71.816
test_09_reboot_router | Success | 35.366
test_09_expunge_vm | Success | 125.286
test_09_destroy_ssvm | Success | 138.583
test_09_delete_detached_volume | Success | 15.532
test_08_start_router | Success | 25.445
test_08_resize_volume | Success | 15.450
test_08_reboot_cpvm | Success | 101.579
test_08_migrate_vm | Success | 36.073
test_08_list_system_templates | Success | 0.063
test_07_stop_router | Success | 10.228
test_07_restore_vm | Success | 0.210
test_07_resize_fail | Success | 20.771
test_07_reboot_ssvm | Success | 103.296
test_07_list_public_templates | Success | 0.047
test_07_list_default_iso | Success | 0.059
test_06_stop_cpvm | Success | 131.867
test_06_router_advanced | Success | 0.064
test_06_download_detached_volume | Success | 15.416
test_06_destroy_vm | Success | 126.422
test_05_template_permissions | Success | 0.176
test_05_stop_ssvm | Success | 133.615
test_05_rvpc_multi_tiers | Success | 419.582
test_05_router_basic | Success | 0.037
test_05_iso_permissions | Success | 0.059
test_05_detach_volume | Success | 100.342
test_04_rvpc_network_garbage_collector_nics | Success | 828.364
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 259.592
test_04_restart_network_wo_cleanup | Success | 5.771
test_04_extract_template | Success | 5.131
test_04_extract_Iso | Success | 5.242
test_04_delete_attached_volume | Success | 10.227
test_04_create_fat_type_disk_offering | Success | 0.068
test_04_cpvm_internals | Success | 1.285
test_04_change_offering_small | Success | 204.910
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 183.876
test_03_ssvm_internals | Success | 3.119
test_03_restart_network_cleanup | Success | 60.884
test_03_reboot_vm | Success | 125.985
test_03_download_attached_volume | Success | 15.543
test_03_delete_template | Success | 5.121
test_03_delete_service_offering | Success | 0.061
test_03_delete_iso | Success | 95.235
test_03_delete_disk_offering | Success | 0.039
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 417.217
test_03_RVR_Network_check_router_state | Success | 255.247
test_02_sys_template_ready | Success | 0.134
test_02_start_vm | Success | 10.244
test_02_router_internal_adv | Success | 1.082
test_02_redundant_VPC_default_routes | Success | 427.037
test_02_port_fwd_on_non_src_nat | Success | 55.935
test_02_list_cpvm_vm | Success | 0.133
test_02_isolate_network_FW_PF_default_routes_egress_false | Success | 197.419
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 575.938
test_02_edit_template | Success | 90.100
test_02_edit_service_offering | Success | 0.054
test_02_edit_iso | Success | 0.080
test_02_edit_disk_offering | Success | 0.061
test_02_deploy_vm_root_resize | Success | 7.245
test_02_create_sparse_type_disk_offering | Success | 0.069
test_02_create_lb_rule_non_nat | Success | 187.561
test_02_attach_volume | Success | 45.403
test_02_VPC_default_routes | Success | 255.289
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Success | 263.448
test_01_vpc_site2site_vpn | Success | 155.352
test_01_updatevolumedetail | Success | 5.118
test_01_sys_vm_start | Success | 0.179
test_01_stop_vm | Success | 40.396
test_01_router_internal_basic | Success | 0.587
test_01_reset_vm_on_reboot | Success | 131.105
test_01_redundant_vpc_site2site_vpn | Success | 226.055
test_01_primary_storage_nfs | Success | 35.989
test_01_port_fwd_on_src_nat | Success | 111.993
test_01_nic | Success | 763.734
test_01_list_sec_storage_vm | Success | 0.154
test_01_isolate_network_FW_PF_default_routes_egress_true | Success | 201.723
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 469.381
test_01_deploy_vm_root_resize | Success | 6.903
test_01_create_volume | Success | 711.919
test_01_create_template | Success | 40.792
test_01_create_service_offering | Success | 0.255
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1011.216
test_01_create_lb_rule_src_nat | Success | 217.930
test_01_create_iso | Success | 67.043
test_01_create_disk_offering | Success | 0.100
test_01_VPC_nics_after_destroy | Success | 447.273
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Success | 249.793
test_00_deploy_vm_root_resize | Success | 244.178
login_test_saml_user | Success | 26.322
test_vm_nic_adapter_vmxnet3 | Skipped | 0.001
test_deploy_vgpu_enabled_vm | Skipped | 0.005
test_06_copy_template | Skipped | 0.000
test_06_copy_iso | Skipped | 0.000
test_03_delete_vm_snapshots | Skipped | 0.000
test_02_revert_vm_snapshots | Skipped | 0.000
test_01_test_vm_volume_snapshot | Skipped | 0.001
test_01_scale_vm | Skipped | 0.001
test_01_primary_storage_iscsi | Skipped | 0.044
test_01_create_vm_snapshots | Skipped | 0.000
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1688: Marvin Tests: Fix VPC network offering selection
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1688
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1688: Marvin Tests: Fix VPC network offering selection
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1688
I've moved the changes to PR #1692 this can be closed now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1688: Marvin Tests: Fix VPC network offering selection
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1688
This has been merged in 4.8+ branches now, please close this @PaulAngus
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1688: Marvin Tests: Fix VPC network offering selection
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1688
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-39
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---