[GitHub] [iceberg] kbendick commented on a diff in pull request #5471: Bump avro from 1.9.2 to 1.11.1

[GitBox <gi...@apache.org>]

kbendick commented on code in PR #5471:
URL: https://github.com/apache/iceberg/pull/5471#discussion_r941711971


##########
hive3/build.gradle:
##########
@@ -96,7 +96,7 @@ project(':iceberg-hive3') {
     testImplementation project(path: ':iceberg-hive-metastore', configuration: 'testArtifacts')
     testImplementation project(path: ':iceberg-data', configuration: 'testArtifacts')
 
-    testImplementation("org.apache.avro:avro:1.9.2")
+    testImplementation("org.apache.avro:avro:1.11.1")

Review Comment:
   I think the Avro version was somewhat unified across parquet, spark, etc a while ago.
   
   But I think that older Hive versions don't necessarily use the same ones. As these are `testImplementation`, I'm assuming that we normally delegate to the underlying engine but need to specify the right version for the engine during tests.
   
   These might be outdated, but several `testImplementation` versions are overridden here.
   
   Do the tests pass with the updated Avro version specified (or the one from `versions.props`)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org