You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by GitBox <gi...@apache.org> on 2021/12/10 21:24:11 UTC
[GitHub] [felix-atomos] rotty3000 opened a new pull request #47: remove direct dependency on Signal so that when jlink is run it doesn…
rotty3000 opened a new pull request #47:
URL: https://github.com/apache/felix-atomos/pull/47
…'t drag in jdk.unsupported just for this one call
Signed-off-by: Raymond Augé <ra...@liferay.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [felix-atomos] rotty3000 closed pull request #47: remove direct dependency on Signal so that when jlink is run it doesn…
Posted by GitBox <gi...@apache.org>.
rotty3000 closed pull request #47:
URL: https://github.com/apache/felix-atomos/pull/47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [felix-atomos] tjwatson commented on pull request #47: remove direct dependency on Signal so that when jlink is run it doesn…
Posted by GitBox <gi...@apache.org>.
tjwatson commented on pull request #47:
URL: https://github.com/apache/felix-atomos/pull/47#issuecomment-991348432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [felix-atomos] rotty3000 commented on pull request #47: remove direct dependency on Signal so that when jlink is run it doesn…
Posted by GitBox <gi...@apache.org>.
rotty3000 commented on pull request #47:
URL: https://github.com/apache/felix-atomos/pull/47#issuecomment-991468851
yeah, this was an experiment but in the end it didn't prove much worth. thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [felix-atomos] rotty3000 edited a comment on pull request #47: remove direct dependency on Signal so that when jlink is run it doesn…
Posted by GitBox <gi...@apache.org>.
rotty3000 edited a comment on pull request #47:
URL: https://github.com/apache/felix-atomos/pull/47#issuecomment-991307696
the LGTM failure seems to be an issue I've also gotten locally. I had to disable the check `<animal.sniffer.skip>true</animal.sniffer.skip>` because it seems the error comes from the felix-parent pom outside this project.
it seems to be malformed version for the signature artifact `org.codehaus.mojo.signature:java111:signature:1.0` (note the 111).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [felix-atomos] rotty3000 closed pull request #47: remove direct dependency on Signal so that when jlink is run it doesn…
Posted by GitBox <gi...@apache.org>.
rotty3000 closed pull request #47:
URL: https://github.com/apache/felix-atomos/pull/47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [felix-atomos] rotty3000 commented on pull request #47: remove direct dependency on Signal so that when jlink is run it doesn…
Posted by GitBox <gi...@apache.org>.
rotty3000 commented on pull request #47:
URL: https://github.com/apache/felix-atomos/pull/47#issuecomment-991307696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [felix-atomos] rotty3000 commented on pull request #47: remove direct dependency on Signal so that when jlink is run it doesn…
Posted by GitBox <gi...@apache.org>.
rotty3000 commented on pull request #47:
URL: https://github.com/apache/felix-atomos/pull/47#issuecomment-991307696
the LGTM failure seems to be an issue I've also gotten locally. I had to disable the check `<animal.sniffer.skip>true</animal.sniffer.skip>` because it seems the error comes from the felix-parent pom outside this project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [felix-atomos] tjwatson commented on pull request #47: remove direct dependency on Signal so that when jlink is run it doesn…
Posted by GitBox <gi...@apache.org>.
tjwatson commented on pull request #47:
URL: https://github.com/apache/felix-atomos/pull/47#issuecomment-991677865
For what it's worth this code is here as a workaround to ensure the shutdown hooks for the jvm are run with native support. It is possible this is no longer needed on the latest graal version. It has been a long time since I've tested with a recent version of graal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [felix-atomos] rotty3000 edited a comment on pull request #47: remove direct dependency on Signal so that when jlink is run it doesn…
Posted by GitBox <gi...@apache.org>.
rotty3000 edited a comment on pull request #47:
URL: https://github.com/apache/felix-atomos/pull/47#issuecomment-991307696
the LGTM failure seems to be an issue I've also gotten locally. I had to disable the check `<animal.sniffer.skip>true</animal.sniffer.skip>` because it seems the error comes from the felix-parent pom outside this project.
it seems to be malformed version for the signature artifact `org.codehaus.mojo.signature:java111:signature:1.0` (note the 111).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [felix-atomos] tjwatson commented on pull request #47: remove direct dependency on Signal so that when jlink is run it doesn…
Posted by GitBox <gi...@apache.org>.
tjwatson commented on pull request #47:
URL: https://github.com/apache/felix-atomos/pull/47#issuecomment-991348432
The `jdk.unsupported` is required optionally (static) already. Not sure why reflection is needed to make it more optional.
```
open module org.apache.felix.atomos
{
exports org.apache.felix.atomos;
requires transitive osgi.core;
requires static osgi.annotation;
requires static jdk.unsupported;
requires static org.apache.felix.gogo.runtime;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org